issue_comments
20 rows where issue = 472100381 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- Initialize empty or full DataArray · 20 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
525022259 | https://github.com/pydata/xarray/pull/3159#issuecomment-525022259 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUyNTAyMjI1OQ== | max-sixty 5635139 | 2019-08-26T20:37:39Z | 2019-08-26T20:37:39Z | MEMBER | Thanks @DangoMelon ! I know this PR was a long road, but it's a material improvement to the ergonomics of xarray. We'd enjoy having you as a contributor in the future! |
{ "total_count": 3, "+1": 0, "-1": 0, "laugh": 0, "hooray": 3, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
525021857 | https://github.com/pydata/xarray/pull/3159#issuecomment-525021857 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUyNTAyMTg1Nw== | max-sixty 5635139 | 2019-08-26T20:36:30Z | 2019-08-26T20:36:30Z | MEMBER | Test failure is the same as on master, ref https://github.com/pydata/xarray/issues/3265 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
525015879 | https://github.com/pydata/xarray/pull/3159#issuecomment-525015879 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUyNTAxNTg3OQ== | griverat 23618263 | 2019-08-26T20:20:17Z | 2019-08-26T20:20:17Z | CONTRIBUTOR |
Thanks for the help! I'm glad to contribute to this project. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
514720305 | https://github.com/pydata/xarray/pull/3159#issuecomment-514720305 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxNDcyMDMwNQ== | pep8speaks 24736507 | 2019-07-24T17:13:50Z | 2019-08-26T20:15:42Z | NONE | Hello @DangoMelon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: Comment last updated at 2019-08-26 20:15:42 UTC |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
525013220 | https://github.com/pydata/xarray/pull/3159#issuecomment-525013220 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUyNTAxMzIyMA== | max-sixty 5635139 | 2019-08-26T20:12:59Z | 2019-08-26T20:12:59Z | MEMBER | Great, looking good @DangoMelon - I merged master to resolve a conflict - then we can get this in! |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
523608375 | https://github.com/pydata/xarray/pull/3159#issuecomment-523608375 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUyMzYwODM3NQ== | max-sixty 5635139 | 2019-08-21T19:11:19Z | 2019-08-21T19:11:19Z | MEMBER | Great, will merge later unless other comments. Will be good to get this in! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
520065496 | https://github.com/pydata/xarray/pull/3159#issuecomment-520065496 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUyMDA2NTQ5Ng== | max-sixty 5635139 | 2019-08-09T21:13:51Z | 2019-08-09T21:13:51Z | MEMBER | Great - will merge unless anyone has final comments? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
519561332 | https://github.com/pydata/xarray/pull/3159#issuecomment-519561332 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxOTU2MTMzMg== | shoyer 1217238 | 2019-08-08T15:12:27Z | 2019-08-08T15:12:27Z | MEMBER | Yes, I think it would make sense to add an option to is_scalar() to indicate whether or not 0-d arrays should be considered "scalars" On Thu, Aug 8, 2019 at 6:44 AM Gerardo Rivera notifications@github.com wrote:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
519524084 | https://github.com/pydata/xarray/pull/3159#issuecomment-519524084 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxOTUyNDA4NA== | griverat 23618263 | 2019-08-08T13:44:22Z | 2019-08-08T13:44:22Z | CONTRIBUTOR |
I was expecting to rely on the current implementation of
Otherwise everything would be filter out since I can only imagine copying |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518908064 | https://github.com/pydata/xarray/pull/3159#issuecomment-518908064 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODkwODA2NA== | max-sixty 5635139 | 2019-08-07T01:57:00Z | 2019-08-07T01:57:00Z | MEMBER |
That's a good point. I think in this case, given that it's passed to an arg expected an array, we should raise on 0d. I realize that's a bit inconsistent with treating them as scalars elsewhere. Happy to be outvoted if others disagree |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518876089 | https://github.com/pydata/xarray/pull/3159#issuecomment-518876089 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODg3NjA4OQ== | griverat 23618263 | 2019-08-06T23:07:34Z | 2019-08-06T23:07:34Z | CONTRIBUTOR | Thanks for the feedback.
Should I treat them like multi-dimensional arrays or leave the current behavior for consistency with the snippet above?
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518822084 | https://github.com/pydata/xarray/pull/3159#issuecomment-518822084 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODgyMjA4NA== | shoyer 1217238 | 2019-08-06T20:02:35Z | 2019-08-06T20:02:35Z | MEMBER | If the default value is |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518811214 | https://github.com/pydata/xarray/pull/3159#issuecomment-518811214 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODgxMTIxNA== | max-sixty 5635139 | 2019-08-06T19:31:28Z | 2019-08-06T19:31:28Z | MEMBER |
👍
👍 ...so for clarity, no need to expose the sentinel values externally, they're an internal implementation that then fills |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518761396 | https://github.com/pydata/xarray/pull/3159#issuecomment-518761396 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODc2MTM5Ng== | shoyer 1217238 | 2019-08-06T17:13:27Z | 2019-08-06T17:13:27Z | MEMBER |
This is the case that I'm not sure we want to support. I think the rule we want is something like "scalar values are repeated automatically," but 0-dimensional arrays are kind of a strange case -- are they really scalars or multi-dimensional arrays? My inclination is to treat these like multi-dimensional arrays, in which case we should raise an error to avoid hiding errors. In particular, one thing that an xarray user might expect, but which I think don't want to support, is full broadcasting of multi-dimensional arrays to match the shape of coordinates.
Rather than using The way we do this in xarray is with a There is also the question of what values should be inside such an empty array. Here I think there are roughly two options:
1. Fill the unspecified array with It looks like you've currently implemented option (2), but again I'm not sure that is the most sensible default behavior for xarray. The performance gains from not filling in array values with a constant are typically very small (writing constant values into memory is very fast). Pandas also seems to use
|
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518752219 | https://github.com/pydata/xarray/pull/3159#issuecomment-518752219 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODc1MjIxOQ== | max-sixty 5635139 | 2019-08-06T16:49:20Z | 2019-08-06T16:49:20Z | MEMBER | Great @DangoMelon , that looks superb! Could you run those cases you listed above in test functions? You can copy and paste those lines, and then compare the resulting object to one constructed with the full array (let me know if this is unclear and I can give more guidance). Could you also construct a test case using @shoyer 's example which fails? Again lmk if you need any guidance in how to do that. In the final case "Use And then I think we can merge, pending any other feedback! Thanks - this will be a valuable addition to xarray. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518747403 | https://github.com/pydata/xarray/pull/3159#issuecomment-518747403 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODc0NzQwMw== | griverat 23618263 | 2019-08-06T16:36:42Z | 2019-08-06T16:36:42Z | CONTRIBUTOR | So far, this addition can do the following:
<xarray.DataArray (x: 3, y: 2)> array([[5, 5], [5, 5], [5, 5]]) Coordinates: * x (x) int64 0 1 2 * y (y) <U1 'a' 'b' ```
<xarray.DataArray (x: 3, y: 2)> array([[1., 1.], [1., 1.], [1., 1.]]) Coordinates: * x (x) int64 0 1 2 * y (y) <U1 'a' 'b' ```
<xarray.DataArray (w: 1, x: 31, y: 2, p: 1, z: 4)> array([[[[[0, ..., 0]],
Coordinates: * x (x) datetime64[ns] 2019-01-01 2019-01-02 ... 2019-01-30 2019-01-31 * y (y) <U5 'north' 'south' * z (z) int64 0 1 2 3 Dimensions without coordinates: w, p ```
```python
<xarray.DataArray (y: 100, p: 10)> array([[ 4.047386e-320, 6.719293e-321, 0.000000e+000, ..., 6.935425e-310, 6.935319e-310, 0.000000e+000], [ 4.940656e-324, 6.935107e-310, 6.935432e-310, ..., 6.935432e-310, 1.086944e-322, 6.935430e-310], [ 6.935432e-310, 6.935319e-310, 2.758595e-313, ..., 6.935432e-310, 6.935432e-310, 6.935432e-310], ..., [ 6.781676e+194, 3.328071e-113, 9.124901e+192, ..., 2.195875e-157, -4.599251e-303, -2.217863e-250], [ 7.830998e+247, -8.407382e+089, 1.299071e+193, ..., 9.124901e+192, -4.661908e-303, 2.897933e+193], [ 1.144295e-309, 7.041423e+053, -8.538757e-210, ..., 1.473665e+256, -6.525461e-210, -1.665001e-075]]) Coordinates: x datetime64[ns] 2019-01-01 * y (y) int64 0 1 2 3 4 5 6 7 8 9 10 ... 90 91 92 93 94 95 96 97 98 99 z <U3 'ST1' * p (p) int64 0 1 2 3 4 5 6 7 8 9 ``` Any comment on what is missing or needs to be fixed is welcome. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518398866 | https://github.com/pydata/xarray/pull/3159#issuecomment-518398866 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODM5ODg2Ng== | griverat 23618263 | 2019-08-05T21:02:27Z | 2019-08-05T21:02:27Z | CONTRIBUTOR | Hi @max-sixty, I managed to fix it up a bit. It previously showed all the commits made by others collaborators since I forked the repo. I did a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518341706 | https://github.com/pydata/xarray/pull/3159#issuecomment-518341706 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODM0MTcwNg== | max-sixty 5635139 | 2019-08-05T18:15:13Z | 2019-08-05T18:15:13Z | MEMBER | Hi @DangoMelon, no stress, I know git can be a pain. I don't remember your previous effort so I'm not sure what the previous version looked like. Is it materially different from what currently exists? The current code looks relevant and @shoyer has reviewed & commented on it. If you have overwritten your previous commits, you can generally get them back by using |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
518306142 | https://github.com/pydata/xarray/pull/3159#issuecomment-518306142 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxODMwNjE0Mg== | griverat 23618263 | 2019-08-05T16:33:22Z | 2019-08-05T16:33:22Z | CONTRIBUTOR | I am not sure what happened to the commit history. I might have messed up trying to update my local fork. Is there anything I can do to revert this? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 | |
514611709 | https://github.com/pydata/xarray/pull/3159#issuecomment-514611709 | https://api.github.com/repos/pydata/xarray/issues/3159 | MDEyOklzc3VlQ29tbWVudDUxNDYxMTcwOQ== | griverat 23618263 | 2019-07-24T12:30:57Z | 2019-07-24T12:30:57Z | CONTRIBUTOR | Just realised most things broke with the change I made. I'll refactor it and try again. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Initialize empty or full DataArray 472100381 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 4