home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 518908064

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3159#issuecomment-518908064 https://api.github.com/repos/pydata/xarray/issues/3159 518908064 MDEyOklzc3VlQ29tbWVudDUxODkwODA2NA== 5635139 2019-08-07T01:57:00Z 2019-08-07T01:57:00Z MEMBER

Should I treat them like multi-dimensional arrays or leave the current behavior for consistency with the snippet above?

That's a good point. I think in this case, given that it's passed to an arg expected an array, we should raise on 0d. I realize that's a bit inconsistent with treating them as scalars elsewhere.

Happy to be outvoted if others disagree

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  472100381
Powered by Datasette · Queries took 0.794ms · About: xarray-datasette