issue_comments: 518876089

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3159#issuecomment-518876089 https://api.github.com/repos/pydata/xarray/issues/3159 518876089 MDEyOklzc3VlQ29tbWVudDUxODg3NjA4OQ== 23618263 2019-08-06T23:07:34Z 2019-08-06T23:07:34Z CONTRIBUTOR

Thanks for the feedback.

My inclination is to treat these like multi-dimensional arrays, in which case we should raise an error to avoid hiding errors.

I wasn't sure on how to treat 0-dimensional arrays and just assumed it to be the same as a scalar since this function considers them as so

https://github.com/pydata/xarray/blob/1ab7569561db50eaccbae977b0ef69993e0c0d0c/xarray/core/utils.py#L238-L248

Should I treat them like multi-dimensional arrays or leave the current behavior for consistency with the snippet above?

If the default value is NaN, we could reuse xarray's pre-existing sentinel value for NA:

Thanks for the advice, I'll be using this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   472100381