issue_comments: 518761396
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3159#issuecomment-518761396 | https://api.github.com/repos/pydata/xarray/issues/3159 | 518761396 | MDEyOklzc3VlQ29tbWVudDUxODc2MTM5Ng== | 1217238 | 2019-08-06T17:13:27Z | 2019-08-06T17:13:27Z | MEMBER |
This is the case that I'm not sure we want to support. I think the rule we want is something like "scalar values are repeated automatically," but 0-dimensional arrays are kind of a strange case -- are they really scalars or multi-dimensional arrays? My inclination is to treat these like multi-dimensional arrays, in which case we should raise an error to avoid hiding errors. In particular, one thing that an xarray user might expect, but which I think don't want to support, is full broadcasting of multi-dimensional arrays to match the shape of coordinates.
Rather than using The way we do this in xarray is with a There is also the question of what values should be inside such an empty array. Here I think there are roughly two options:
1. Fill the unspecified array with It looks like you've currently implemented option (2), but again I'm not sure that is the most sensible default behavior for xarray. The performance gains from not filling in array values with a constant are typically very small (writing constant values into memory is very fast). Pandas also seems to use
|
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
472100381 |