issue_comments: 518752219
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/3159#issuecomment-518752219 | https://api.github.com/repos/pydata/xarray/issues/3159 | 518752219 | MDEyOklzc3VlQ29tbWVudDUxODc1MjIxOQ== | 5635139 | 2019-08-06T16:49:20Z | 2019-08-06T16:49:20Z | MEMBER | Great @DangoMelon , that looks superb! Could you run those cases you listed above in test functions? You can copy and paste those lines, and then compare the resulting object to one constructed with the full array (let me know if this is unclear and I can give more guidance). Could you also construct a test case using @shoyer 's example which fails? Again lmk if you need any guidance in how to do that. In the final case "Use And then I think we can merge, pending any other feedback! Thanks - this will be a valuable addition to xarray. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
472100381 |