issues

Table actions

10 rows where type = "pull" and user = 44147817 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 10 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1050367667 PR_kwDOAMm_X84uYCxJ 5972 Respect keep_attrs when using `Dataset.set_index` (#4955) gcaria 44147817 closed 0     6 2021-11-10T22:22:31Z 2023-10-03T00:09:41Z 2023-10-03T00:09:41Z CONTRIBUTOR   0 pydata/xarray/pulls/5972
  • [x] Closes #4955
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

The original issue was about DataArray.set_index, but since this simply calls Dataset.set_index, I have only added a test for the latter. DataArray.set_index probably deserves a test too, please let me know what you think.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5972/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
963006707 MDExOlB1bGxSZXF1ZXN0NzA1NzEzMTc1 5680 ENH: Add default fill values for decode_cf gcaria 44147817 open 0     8 2021-08-06T19:54:05Z 2022-06-09T14:50:16Z   CONTRIBUTOR   0 pydata/xarray/pulls/5680
  • [x] Closes #2374
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

This is a work in progress, mostly so that I can ask some clarifying questions.

I see that netCDF4 is an optional dependency for xarray, so probably import netCDF4 can't be used. Should xarray simply hard-code default fill values ?

From the issue's conversation, it wasn't clear to me whether an argument should control the use of the default fill value. Since some tests fail now I guess the answer is yes. 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5680/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1048012238 PR_kwDOAMm_X84uQWuF 5957 Do not change coordinate inplace when throwing error gcaria 44147817 closed 0     2 2021-11-08T23:10:22Z 2021-11-09T20:28:13Z 2021-11-09T20:28:13Z CONTRIBUTOR   0 pydata/xarray/pulls/5957
  • [x] Closes #5036
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Not the prettiest of fixes, but this goes around the fact that mutable data types (e.g. when self_data is a np.ndarray) get updated inplace on the right-hand side of the following line, while the error is thrown during the subsequent assignment to the left-hand side.

https://github.com/pydata/xarray/blob/20fddb7e3838d3cf1514476899e77a8a1749734b/xarray/core/variable.py#L2421

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5957/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
945600101 MDExOlB1bGxSZXF1ZXN0NjkwOTA2NTky 5611 Set coord name concat when `concat`ing along a DataArray gcaria 44147817 closed 0     4 2021-07-15T17:20:54Z 2021-08-23T17:24:43Z 2021-08-23T17:00:39Z CONTRIBUTOR   0 pydata/xarray/pulls/5611
  • [x] Closes #5240
  • [x] Tests added
  • [x] Passes pre-commit run --all-files

Technically this creates user visible changes, but not sure whether it's worth adding it to the whatsnew.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5611/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
973934781 MDExOlB1bGxSZXF1ZXN0NzE1MzEzMDEz 5713 DOC: Remove suggestion to install pytest-xdist in docs gcaria 44147817 closed 0     2 2021-08-18T18:14:47Z 2021-08-19T22:16:24Z 2021-08-19T22:16:19Z CONTRIBUTOR   0 pydata/xarray/pulls/5713
  • [x] Closes #5679
  • [x] Passes pre-commit run --all-files
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5713/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
938905952 MDExOlB1bGxSZXF1ZXN0Njg1MjA3MTQ5 5586 Accept missing_dims in Variable.transpose and Dataset.transpose gcaria 44147817 closed 0     4 2021-07-07T13:39:15Z 2021-07-17T21:03:00Z 2021-07-17T21:02:59Z CONTRIBUTOR   0 pydata/xarray/pulls/5586
  • [x] Closes #5550
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Regarding https://github.com/pydata/xarray/issues/5550#issuecomment-875040245, inside the for loop only a Variable's dimensions are selected for the transpose, so a dimension that it's missing in all DataArrays would just be ignored silently. Hence it's necessary to check at the beginning of the function.

https://github.com/pydata/xarray/blob/5489effbe7d83451a75382f842c4f5f96ead069f/xarray/core/dataset.py#L4591

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5586/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
891760873 MDExOlB1bGxSZXF1ZXN0NjQ0NTc3MDMx 5308 Move encode expected test failures to own function gcaria 44147817 closed 0     1 2021-05-14T09:17:30Z 2021-05-14T10:06:20Z 2021-05-14T10:06:13Z CONTRIBUTOR   0 pydata/xarray/pulls/5308

A quick fix for a missing commit of PR #5288

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5308/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
885038560 MDExOlB1bGxSZXF1ZXN0NjM4MzgxMzUy 5288 Raise error for invalid reference date for encoding time units gcaria 44147817 closed 0     7 2021-05-10T20:25:23Z 2021-05-14T09:43:30Z 2021-05-13T18:27:13Z CONTRIBUTOR   0 pydata/xarray/pulls/5288
  • [x] Closes #5199
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Although the error raised by this commit does not include the whole units string, I believe it is actually more useful and specific since it focuses on the part (reference date) that's actually causing the problem. Also, the reference date is the only information available in coding.times._ensure_padded_year, so this is the simplest way of raising an error.

I had a look in tests/test_coding_times.py and could not find a test for this related error raising (since I'd put a test for this commit around there) https://github.com/pydata/xarray/blob/234b40a37e484a795e6b12916315c80d70570b27/xarray/coding/times.py#L127-L129

Have I missed it?

EDIT: I've tried to substitute the error raise on line 129 with a pass and all the tests passed anyway.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5288/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
874044225 MDExOlB1bGxSZXF1ZXN0NjI4Njc2ODUz 5247 Add to_pandas method for Dataset gcaria 44147817 closed 0     3 2021-05-02T21:04:53Z 2021-05-04T13:56:17Z 2021-05-04T13:56:00Z CONTRIBUTOR   0 pydata/xarray/pulls/5247
  • [x] Closes #255
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5247/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
867046262 MDExOlB1bGxSZXF1ZXN0NjIyNzkwOTcx 5216 Enable using __setitem__ for Dataset using a list as key gcaria 44147817 closed 0     8 2021-04-25T15:57:48Z 2021-05-02T20:30:26Z 2021-05-02T20:29:34Z CONTRIBUTOR   0 pydata/xarray/pulls/5216
  • [x] Closes #1123
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Hi xarray folks, long time user first time contributor here.

I believe the tests for this feature should be expanded, so please consider this as a work in progress. Any feedback is greatly appreciated!

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5216/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);