issues: 963006707

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
963006707 MDExOlB1bGxSZXF1ZXN0NzA1NzEzMTc1 5680 ENH: Add default fill values for decode_cf 44147817 open 0     8 2021-08-06T19:54:05Z 2022-06-09T14:50:16Z   CONTRIBUTOR   0 pydata/xarray/pulls/5680
  • [x] Closes #2374
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

This is a work in progress, mostly so that I can ask some clarifying questions.

I see that netCDF4 is an optional dependency for xarray, so probably import netCDF4 can't be used. Should xarray simply hard-code default fill values ?

From the issue's conversation, it wasn't clear to me whether an argument should control the use of the default fill value. Since some tests fail now I guess the answer is yes. 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5680/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables