home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 938905952

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
938905952 MDExOlB1bGxSZXF1ZXN0Njg1MjA3MTQ5 5586 Accept missing_dims in Variable.transpose and Dataset.transpose 44147817 closed 0     4 2021-07-07T13:39:15Z 2021-07-17T21:03:00Z 2021-07-17T21:02:59Z CONTRIBUTOR   0 pydata/xarray/pulls/5586
  • [x] Closes #5550
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Regarding https://github.com/pydata/xarray/issues/5550#issuecomment-875040245, inside the for loop only a Variable's dimensions are selected for the transpose, so a dimension that it's missing in all DataArrays would just be ignored silently. Hence it's necessary to check at the beginning of the function.

https://github.com/pydata/xarray/blob/5489effbe7d83451a75382f842c4f5f96ead069f/xarray/core/dataset.py#L4591

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5586/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 1 row from issues_id in issues_labels
  • 4 rows from issue in issue_comments
Powered by Datasette · Queries took 234.5ms · About: xarray-datasette