issues: 1048012238

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1048012238 PR_kwDOAMm_X84uQWuF 5957 Do not change coordinate inplace when throwing error 44147817 closed 0     2 2021-11-08T23:10:22Z 2021-11-09T20:28:13Z 2021-11-09T20:28:13Z CONTRIBUTOR   0 pydata/xarray/pulls/5957
  • [x] Closes #5036
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Not the prettiest of fixes, but this goes around the fact that mutable data types (e.g. when self_data is a np.ndarray) get updated inplace on the right-hand side of the following line, while the error is thrown during the subsequent assignment to the left-hand side.

https://github.com/pydata/xarray/blob/20fddb7e3838d3cf1514476899e77a8a1749734b/xarray/core/variable.py#L2421

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5957/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables