issues

Table actions

10 rows where repo = 13221727, type = "pull" and user = 3698640 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 10 ✖

state 1

repo 1

  • xarray · 10 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1221393104 PR_kwDOAMm_X843GASj 6542 docs on specifying chunks in to_zarr encoding arg delgadom 3698640 closed 0     17 2022-04-29T18:37:25Z 2022-07-01T01:20:19Z 2022-06-23T21:31:37Z CONTRIBUTOR   0 pydata/xarray/pulls/6542

The structure of the Dataset.to_zarr encoding argument is particular to xarray (at least, it's not immediately obvious from the zarr docs how this argument gets parsed) and it took a bit of trial and error to figure out out the rules. Hoping this docs block is helpful to others!

Documentation additions only (no workflow stages)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6542/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1199127752 PR_kwDOAMm_X8419bFr 6467 allow other and drop arguments in where (gh#6466) delgadom 3698640 closed 0     7 2022-04-10T18:03:24Z 2022-04-12T16:39:53Z 2022-04-12T15:33:05Z CONTRIBUTOR   0 pydata/xarray/pulls/6467
  • [x] Closes #6466
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst - not sure if this is warranted or if it should go in new features or bug fixes. happy to change/remove.
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6467/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1094882077 PR_kwDOAMm_X84wllP5 6144 allow 1 non-null value in interpolate_na with method="nearest" delgadom 3698640 closed 0     2 2022-01-06T01:28:17Z 2022-01-19T03:33:19Z 2022-01-18T22:45:39Z CONTRIBUTOR   0 pydata/xarray/pulls/6144
  • [x] Closes #5994
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

@Skealz's great issue (#5994) highlighted that DataArrays with a single non-null value raise an error if DataArray.interpolate_na is called with method='nearest'. Note that this does not occur for the default (method='linear').

In this PR: * Uses the "fast track" to quickly return any 1-D slices with a single non-null value in addition to the previous all-nan or no-nan fasttrack * Explicitly check this behavior for all 1-D interpolation methods using parametrized tests * consolidate other fast-track tests (interpolate_allnans and interpolate_nonans) into a single parameterized test

For discussion: * This patch may break existing workflows if they rely on the current behavior, which errors for slices with only a single value

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6144/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1090749099 PR_kwDOAMm_X84wYTL_ 6126 Deprecate bool(ds) delgadom 3698640 closed 0     1 2021-12-29T21:06:28Z 2022-01-04T01:23:02Z 2022-01-03T16:57:58Z CONTRIBUTOR   0 pydata/xarray/pulls/6126

Issues a PendingDeprecationWarning on Dataset.__bool__

  • [x] Closes #6124
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst <-- could definitely use a review
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6126/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1090226596 PR_kwDOAMm_X84wWmUG 6123 assert ds errors in test_dataset.py delgadom 3698640 closed 0     1 2021-12-29T02:24:21Z 2021-12-31T22:22:16Z 2021-12-29T06:17:33Z CONTRIBUTOR   0 pydata/xarray/pulls/6123

a number of assert statements in test_dataset.py::test_clip make assertions which will never fail as long as there is at least one data_variable:

python assert result.min(...) >= 0.5 this evaluates to datasets with scalar True or False values in each data_variable; however, ds.__bool__ returns true if len(ds.data_vars) > 0.

related: https://github.com/pydata/xarray/pull/6122

No workflow stages here - I just made the changes in the browser. Pretty simple patch that increases the effectiveness of existing tests - no changes to the xarray core code. Let me know if you'd like me to implement any of the normal checks.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6123/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1090221330 PR_kwDOAMm_X84wWlSA 6122 assert ds errors in test_backends delgadom 3698640 closed 0     1 2021-12-29T02:06:23Z 2021-12-31T22:21:55Z 2021-12-29T06:24:50Z CONTRIBUTOR   0 pydata/xarray/pulls/6122

Makes four changes to xarray/tests/test_backends.py::test_open_fsspec

Previously, there were four inequality tests which will always pass regardless of whether the read was successful.

assert ds0 == ds2 will always evaluate to True if the datasets have at least one data variable. Instead, xr.testing.assert_equal should be used to test data variable equality.

No workflow stages here - I just made the changes in the browser. Pretty simple patch that increases the effectiveness of existing tests - no changes to the xarray core code.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6122/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1076015390 PR_kwDOAMm_X84vovaU 6056 add set_options link to FAQ on metadata delgadom 3698640 closed 0     1 2021-12-09T21:04:21Z 2021-12-15T06:21:18Z 2021-12-09T21:39:45Z CONTRIBUTOR   0 pydata/xarray/pulls/6056

If helpful - added a PR to adds a reference and link to xr.set_options in the section of the FAQ on "what is your approach to metadata?". I had to do a bit of digging to figure out what was meant by "there is a global flag" and thought others might find the direct ref useful.

Relevant section: https://github.com/pydata/xarray/blob/main/doc/getting-started-guide/faq.rst#what-is-your-approach-to-metadata

Current text:

An implication of this choice is that we do not propagate attrs through most operations unless explicitly flagged (some methods have a keep_attrs option, and there is a global flag for setting this to be always True or False)

Proposed version:

An implication of this choice is that we do not propagate attrs through most operations unless explicitly flagged (some methods have a keep_attrs option, and there is a global flag, accessible with xr.set_options, for setting this to be always True or False).

Minor docs change only. No workflow steps needed.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6056/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1066620057 PR_kwDOAMm_X84vKEIh 6034 fix grammatical typo in docs delgadom 3698640 closed 0     1 2021-11-29T23:48:10Z 2021-11-30T00:33:07Z 2021-11-30T00:33:07Z CONTRIBUTOR   0 pydata/xarray/pulls/6034

very simple fix in the broadcasting by dimension name docs:

DataArray objects ~~are~~ automatically align themselves [...] by dimension name instead of axis order.

No workflow stages - this is a very minor docs fix.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6034/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
316507797 MDExOlB1bGxSZXF1ZXN0MTgzMjMyMjQx 2072 resolve #2071: 'bebroadcast' in ValueError msg delgadom 3698640 closed 0     1 2018-04-21T17:02:44Z 2018-04-21T17:42:11Z 2018-04-21T17:42:06Z CONTRIBUTOR   0 pydata/xarray/pulls/2072

Simple spelling correction.

Add space to end of line halfway through error message on line 682 to avoid 'bebroadcast' on string concatenation.

  • [x] Closes #2071
  • ~~Tests added (for all bug fixes or enhancements)~~
  • [ ] Tests passed (for all non-documentation changes)
  • ~~Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2072/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
285006452 MDExOlB1bGxSZXF1ZXN0MTYwNDU0NDIw 1802 Handle _FillValue in variable-length unicode string variables delgadom 3698640 closed 0     3 2017-12-28T23:13:54Z 2018-01-11T23:56:57Z 2018-01-11T23:56:57Z CONTRIBUTOR   0 pydata/xarray/pulls/1802
  • [x] Closes #1781
  • [x] Tests added
  • [x] Tests passed
  • [x] Passes git diff upstream/master **/*py | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

For testing - I could use some guidance. Not sure if it's worth creating a fixture set or something just for this issue. If so, would that go in test_backends?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1802/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);