home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 1090221330

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1090221330 PR_kwDOAMm_X84wWlSA 6122 assert ds errors in test_backends 3698640 closed 0     1 2021-12-29T02:06:23Z 2021-12-31T22:21:55Z 2021-12-29T06:24:50Z CONTRIBUTOR   0 pydata/xarray/pulls/6122

Makes four changes to xarray/tests/test_backends.py::test_open_fsspec

Previously, there were four inequality tests which will always pass regardless of whether the read was successful.

assert ds0 == ds2 will always evaluate to True if the datasets have at least one data variable. Instead, xr.testing.assert_equal should be used to test data variable equality.

No workflow stages here - I just made the changes in the browser. Pretty simple patch that increases the effectiveness of existing tests - no changes to the xarray core code.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6122/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 3.548ms · About: xarray-datasette