issues: 1090226596
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1090226596 | PR_kwDOAMm_X84wWmUG | 6123 | assert ds errors in test_dataset.py | 3698640 | closed | 0 | 1 | 2021-12-29T02:24:21Z | 2021-12-31T22:22:16Z | 2021-12-29T06:17:33Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/6123 | a number of assert statements in test_dataset.py::test_clip make assertions which will never fail as long as there is at least one data_variable:
related: https://github.com/pydata/xarray/pull/6122 No workflow stages here - I just made the changes in the browser. Pretty simple patch that increases the effectiveness of existing tests - no changes to the xarray core code. Let me know if you'd like me to implement any of the normal checks. |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/6123/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |