home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 1094882077

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1094882077 PR_kwDOAMm_X84wllP5 6144 allow 1 non-null value in interpolate_na with method="nearest" 3698640 closed 0     2 2022-01-06T01:28:17Z 2022-01-19T03:33:19Z 2022-01-18T22:45:39Z CONTRIBUTOR   0 pydata/xarray/pulls/6144
  • [x] Closes #5994
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

@Skealz's great issue (#5994) highlighted that DataArrays with a single non-null value raise an error if DataArray.interpolate_na is called with method='nearest'. Note that this does not occur for the default (method='linear').

In this PR: * Uses the "fast track" to quickly return any 1-D slices with a single non-null value in addition to the previous all-nan or no-nan fasttrack * Explicitly check this behavior for all 1-D interpolation methods using parametrized tests * consolidate other fast-track tests (interpolate_allnans and interpolate_nonans) into a single parameterized test

For discussion: * This patch may break existing workflows if they rely on the current behavior, which errors for slices with only a single value

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6144/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 1 row from issues_id in issues_labels
  • 2 rows from issue in issue_comments
Powered by Datasette · Queries took 79.114ms · About: xarray-datasette