issue_comments

Table actions

13 rows where user = 44147817 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • gcaria · 13 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1398072586 https://github.com/pydata/xarray/issues/7409#issuecomment-1398072586 https://api.github.com/repos/pydata/xarray/issues/7409 IC_kwDOAMm_X85TVOUK gcaria 44147817 2023-01-20T08:39:31Z 2023-01-20T08:39:31Z CONTRIBUTOR

Yes I did, but unfortunately I didn't think about the trick of converting to Dataset. My only thought then is that it'd be nice to also get a dask Series, so something like to_dask instead of to_dask_dataframe, which I guess entails adding a DataFrame.squeeze() somewhere in the existing to_dask_dataframe code.

Feel free to close this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement `DataArray.to_dask_dataframe()` 1517575123
1073312888 https://github.com/pydata/xarray/issues/6288#issuecomment-1073312888 https://api.github.com/repos/pydata/xarray/issues/6288 IC_kwDOAMm_X84_-XR4 gcaria 44147817 2022-03-20T19:04:45Z 2022-03-20T19:04:45Z CONTRIBUTOR

By the way, the docstring of open_zarr fails to mention that decode_coords could be a string too (and what the accepted string values mean)

https://github.com/pydata/xarray/blob/fed852073eee883c0ed1e13e28e508ff0cf9d5c1/xarray/backends/zarr.py#L687-L689

Should I open a separate issue for this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr()` does not preserve CRS information 1143489702
1071510084 https://github.com/pydata/xarray/issues/6288#issuecomment-1071510084 https://api.github.com/repos/pydata/xarray/issues/6288 IC_kwDOAMm_X84_3fJE gcaria 44147817 2022-03-17T21:20:02Z 2022-03-17T21:20:02Z CONTRIBUTOR

Thanks @snowman2, that makes the CRS readable 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr()` does not preserve CRS information 1143489702
964446445 https://github.com/pydata/xarray/pull/5957#issuecomment-964446445 https://api.github.com/repos/pydata/xarray/issues/5957 IC_kwDOAMm_X845fEjt gcaria 44147817 2021-11-09T19:02:40Z 2021-11-09T19:02:40Z CONTRIBUTOR

Thanks @shoyer for the feedback. Now IndexVariable._inplace_binary_op will just throw an error whenever it is called.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not change coordinate inplace when throwing error 1048012238
903319391 https://github.com/pydata/xarray/pull/5611#issuecomment-903319391 https://api.github.com/repos/pydata/xarray/issues/5611 IC_kwDOAMm_X841149f gcaria 44147817 2021-08-22T19:34:15Z 2021-08-22T19:34:15Z CONTRIBUTOR

No worries @max-sixty, rebased to main and all tests work fine now!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set coord name concat when `concat`ing along a DataArray 945600101
894819235 https://github.com/pydata/xarray/pull/5680#issuecomment-894819235 https://api.github.com/repos/pydata/xarray/issues/5680 IC_kwDOAMm_X841Vduj gcaria 44147817 2021-08-08T16:07:54Z 2021-08-08T16:07:54Z CONTRIBUTOR

I would have liked to add the dictionary in xarray.conventions but this causes circular imports.

It seems that a lot of test failures are caused by something like: ```python

xarray.core.dtypes.maybe_promote(dtype('int64'))

(dtype('float64'), nan ````

So the answer to this must really be yes, am I right?

From the issue's conversation, it wasn't clear to me whether an argument should control the use of the default fill value. Since some tests fail now I guess the answer is yes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Add default fill values for decode_cf 963006707
881870405 https://github.com/pydata/xarray/issues/2374#issuecomment-881870405 https://api.github.com/repos/pydata/xarray/issues/2374 IC_kwDOAMm_X840kEZF gcaria 44147817 2021-07-17T09:58:13Z 2021-07-17T09:58:13Z CONTRIBUTOR

This is still relevant, should the argument decode_cf deal with it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Suggestion: Add option for default_fillvals to open_dataset 351846466
881339035 https://github.com/pydata/xarray/issues/5531#issuecomment-881339035 https://api.github.com/repos/pydata/xarray/issues/5531 IC_kwDOAMm_X840iCqb gcaria 44147817 2021-07-16T10:16:14Z 2021-07-16T10:16:14Z CONTRIBUTOR

This is done neatly in pandas with a decorator (see here) that takes care of the deprecation.

Would it be fine to just implement the same in xarray?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keyword only args for arguments like "drop" 929840699
873437513 https://github.com/pydata/xarray/issues/5550#issuecomment-873437513 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3MzQzNzUxMw== gcaria 44147817 2021-07-03T17:00:01Z 2021-07-03T17:00:01Z CONTRIBUTOR

I've noticed that Dataset.transpose calls Variable.transpose, which does not support missing_dims either. It is interesting that both DataArray.transpose and Variable.transpose use utils.infix_dims, but only the former takes advantage of its missing_dims argument.

https://github.com/pydata/xarray/blob/3d1d134278bbf5cabdd176d42787a05eba23730d/xarray/core/dataarray.py#L2250-L2251

https://github.com/pydata/xarray/blob/3d1d134278bbf5cabdd176d42787a05eba23730d/xarray/core/variable.py#L1407

Should Dataset and Variable just copy what's done for DataArray ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183
849170412 https://github.com/pydata/xarray/issues/4997#issuecomment-849170412 https://api.github.com/repos/pydata/xarray/issues/4997 MDEyOklzc3VlQ29tbWVudDg0OTE3MDQxMg== gcaria 44147817 2021-05-26T22:49:13Z 2021-05-26T22:49:13Z CONTRIBUTOR

I started working on this, and quickly ran into the obstacle of not being able to differentiate points according to marker style (at least in a single call to plt.scatter), basically this https://github.com/matplotlib/matplotlib/issues/11155

Setting up several calls to plt.scatter (one for each marker style and related set of points) seems like a terrible idea to me, so I guess adding a marker argument would only make sense if the user wants to do it manually (several Dataset.plot.scatter calls) for the same figure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include a markertype in `Dataset.plot.scatter` 822404281
840845930 https://github.com/pydata/xarray/pull/5288#issuecomment-840845930 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDg0NTkzMA== gcaria 44147817 2021-05-13T21:28:36Z 2021-05-13T21:28:36Z CONTRIBUTOR

Hi @dcherian, thanks for the merge, however I think there was one last edit left for this PR, i.e. put the tests in their own function. How should I go about this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
840008512 https://github.com/pydata/xarray/pull/5288#issuecomment-840008512 https://api.github.com/repos/pydata/xarray/issues/5288 MDEyOklzc3VlQ29tbWVudDg0MDAwODUxMg== gcaria 44147817 2021-05-12T18:33:50Z 2021-05-12T18:33:50Z CONTRIBUTOR

Done :) Since it was very little effort, I've also added a test for the other related error raising.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error for invalid reference date for encoding time units 885038560
830657777 https://github.com/pydata/xarray/pull/5216#issuecomment-830657777 https://api.github.com/repos/pydata/xarray/issues/5216 MDEyOklzc3VlQ29tbWVudDgzMDY1Nzc3Nw== gcaria 44147817 2021-05-01T16:27:13Z 2021-05-01T16:27:13Z CONTRIBUTOR

Thanks all for the feedback ! This thread it's getting a bit hard to follow, but I believe this is the only suggested change that I haven't applied https://github.com/pydata/xarray/pull/5216#discussion_r624062989

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable using __setitem__ for Dataset using a list as key 867046262

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);