issue_comments: 894819235

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5680#issuecomment-894819235 https://api.github.com/repos/pydata/xarray/issues/5680 894819235 IC_kwDOAMm_X841Vduj 44147817 2021-08-08T16:07:54Z 2021-08-08T16:07:54Z CONTRIBUTOR

I would have liked to add the dictionary in xarray.conventions but this causes circular imports.

It seems that a lot of test failures are caused by something like: ```python

xarray.core.dtypes.maybe_promote(dtype('int64'))

(dtype('float64'), nan ````

So the answer to this must really be yes, am I right?

From the issue's conversation, it wasn't clear to me whether an argument should control the use of the default fill value. Since some tests fail now I guess the answer is yes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   963006707