home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

2 rows where issue = 985162305 and user = 14371165 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • Illviljan · 2 ✖

issue 1

  • Mypy errors with the last version of _typed_ops.pyi · 2 ✖

author_association 1

  • MEMBER 2
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
910464045 https://github.com/pydata/xarray/issues/5755#issuecomment-910464045 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842RJQt Illviljan 14371165 2021-09-01T16:45:47Z 2021-09-01T17:08:14Z MEMBER

Before T_Dataset etc. was: https://github.com/pydata/xarray/blob/d58a5114ccc8656e83d8a31eebf720548f004f86/xarray/core/_typed_ops.pyi#L20-L22

Now it is: https://github.com/pydata/xarray/blob/6b59d9a5058adb8de1661f49bc273aa78d6de7de/xarray/core/types.py#L20-L22

This seems fixable by adding back https://github.com/pydata/xarray/blob/d58a5114ccc8656e83d8a31eebf720548f004f86/xarray/core/_typed_ops.pyi#L19-L22

What I wonder about is why we called it T_Dataset instead of T_DatasetOpsMixin? Is it a trick to make it look good in docs or?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Mypy errors with the last version of _typed_ops.pyi  985162305
910480241 https://github.com/pydata/xarray/issues/5755#issuecomment-910480241 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842RNNx Illviljan 14371165 2021-09-01T17:05:57Z 2021-09-01T17:05:57Z MEMBER

What I wonder about is why we called it T_Dataset instead of T_DatasetOpsMixin? Is it a trick to make it look good in docs or?

The goal was for the type that's used throughout Xarray to be called T_Dataset, but not sure why that means we have to change the definition — I don't think there's a good reason.

Should we change that back, and change the mypy file files definition to .py[i]?

Agreed and maybe add a comment/TODO why it's called T_Dataset instead of T_DatasetOpsMixin if there is any reason.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Mypy errors with the last version of _typed_ops.pyi  985162305

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 31.775ms · About: xarray-datasette