home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 910480241

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5755#issuecomment-910480241 https://api.github.com/repos/pydata/xarray/issues/5755 910480241 IC_kwDOAMm_X842RNNx 14371165 2021-09-01T17:05:57Z 2021-09-01T17:05:57Z MEMBER

What I wonder about is why we called it T_Dataset instead of T_DatasetOpsMixin? Is it a trick to make it look good in docs or?

The goal was for the type that's used throughout Xarray to be called T_Dataset, but not sure why that means we have to change the definition — I don't think there's a good reason.

Should we change that back, and change the mypy file files definition to .py[i]?

Agreed and maybe add a comment/TODO why it's called T_Dataset instead of T_DatasetOpsMixin if there is any reason.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  985162305
Powered by Datasette · Queries took 0.572ms · About: xarray-datasette