issue_comments

Table actions

5 rows where issue = 985162305 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Mypy errors with the last version of _typed_ops.pyi · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
918073632 https://github.com/pydata/xarray/issues/5755#issuecomment-918073632 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842uLEg benbovy 4160723 2021-09-13T10:53:16Z 2021-09-13T10:53:16Z MEMBER

Thank you very much @max-sixty and @Illviljan for looking into this and for the PR!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Mypy errors with the last version of _typed_ops.pyi  985162305
910464045 https://github.com/pydata/xarray/issues/5755#issuecomment-910464045 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842RJQt Illviljan 14371165 2021-09-01T16:45:47Z 2021-09-01T17:08:14Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Mypy errors with the last version of _typed_ops.pyi  985162305
910480241 https://github.com/pydata/xarray/issues/5755#issuecomment-910480241 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842RNNx Illviljan 14371165 2021-09-01T17:05:57Z 2021-09-01T17:05:57Z MEMBER

What I wonder about is why we called it T_Dataset instead of T_DatasetOpsMixin? Is it a trick to make it look good in docs or?

The goal was for the type that's used throughout Xarray to be called T_Dataset, but not sure why that means we have to change the definition — I don't think there's a good reason.

Should we change that back, and change the mypy file files definition to .py[i]?

Agreed and maybe add a comment/TODO why it's called T_Dataset instead of T_DatasetOpsMixin if there is any reason.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Mypy errors with the last version of _typed_ops.pyi  985162305
910467901 https://github.com/pydata/xarray/issues/5755#issuecomment-910467901 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842RKM9 max-sixty 5635139 2021-09-01T16:50:56Z 2021-09-01T16:50:56Z MEMBER

What I wonder about is why we called it T_Dataset instead of T_DatasetOpsMixin? Is it a trick to make it look good in docs or?

The goal was for the type that's used throughout Xarray to be called T_Dataset, but not sure why that means we have to change the definition — I don't think there's a good reason.

Should we change that back, and change the mypy file files definition to .py[i]?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Mypy errors with the last version of _typed_ops.pyi  985162305
910464246 https://github.com/pydata/xarray/issues/5755#issuecomment-910464246 https://api.github.com/repos/pydata/xarray/issues/5755 IC_kwDOAMm_X842RJT2 max-sixty 5635139 2021-09-01T16:46:03Z 2021-09-01T16:47:01Z MEMBER

Edit: @Illviljan and I commented at the same time, he seems to have found the error!

Great spot @benbovy . I think what's happening is that the standard run only checks .py files, rather than .pyi files. So mypy . collects it, but pre-commit and mypy doesn't.

ref https://github.com/pre-commit/mirrors-mypy/issues/33 for the pre-commit issue.

On the errors themselves — @rhkleijn I think I have upset your magnum opus despite the best of intentions. If you're up for having a look, that would be great. Otherwise we could try and revert my original PR, though I worry this sort of refactor is difficult to revert.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Mypy errors with the last version of _typed_ops.pyi  985162305

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);