issue_comments

Table actions

9 rows where issue = 472100381 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 9 ✖

issue 1

  • Initialize empty or full DataArray · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
525022259 https://github.com/pydata/xarray/pull/3159#issuecomment-525022259 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUyNTAyMjI1OQ== max-sixty 5635139 2019-08-26T20:37:39Z 2019-08-26T20:37:39Z MEMBER

Thanks @DangoMelon ! I know this PR was a long road, but it's a material improvement to the ergonomics of xarray. We'd enjoy having you as a contributor in the future!

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 3,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
525021857 https://github.com/pydata/xarray/pull/3159#issuecomment-525021857 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUyNTAyMTg1Nw== max-sixty 5635139 2019-08-26T20:36:30Z 2019-08-26T20:36:30Z MEMBER

Test failure is the same as on master, ref https://github.com/pydata/xarray/issues/3265

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
525013220 https://github.com/pydata/xarray/pull/3159#issuecomment-525013220 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUyNTAxMzIyMA== max-sixty 5635139 2019-08-26T20:12:59Z 2019-08-26T20:12:59Z MEMBER

Great, looking good @DangoMelon - I merged master to resolve a conflict - then we can get this in!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
523608375 https://github.com/pydata/xarray/pull/3159#issuecomment-523608375 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUyMzYwODM3NQ== max-sixty 5635139 2019-08-21T19:11:19Z 2019-08-21T19:11:19Z MEMBER

Great, will merge later unless other comments. Will be good to get this in!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
520065496 https://github.com/pydata/xarray/pull/3159#issuecomment-520065496 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUyMDA2NTQ5Ng== max-sixty 5635139 2019-08-09T21:13:51Z 2019-08-09T21:13:51Z MEMBER

Great - will merge unless anyone has final comments?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
518908064 https://github.com/pydata/xarray/pull/3159#issuecomment-518908064 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUxODkwODA2NA== max-sixty 5635139 2019-08-07T01:57:00Z 2019-08-07T01:57:00Z MEMBER

Should I treat them like multi-dimensional arrays or leave the current behavior for consistency with the snippet above?

That's a good point. I think in this case, given that it's passed to an arg expected an array, we should raise on 0d. I realize that's a bit inconsistent with treating them as scalars elsewhere.

Happy to be outvoted if others disagree

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
518811214 https://github.com/pydata/xarray/pull/3159#issuecomment-518811214 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUxODgxMTIxNA== max-sixty 5635139 2019-08-06T19:31:28Z 2019-08-06T19:31:28Z MEMBER
  1. Fill the unspecified array with np.nan, to indicate invalid values.

👍

If users want an empty DataArray, make them omit the argument entirely, e.g., xr.DataArray(coord=coords, dims=dims).

👍

...so for clarity, no need to expose the sentinel values externally, they're an internal implementation that then fills np.nans

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
518752219 https://github.com/pydata/xarray/pull/3159#issuecomment-518752219 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUxODc1MjIxOQ== max-sixty 5635139 2019-08-06T16:49:20Z 2019-08-06T16:49:20Z MEMBER

Great @DangoMelon , that looks superb!

Could you run those cases you listed above in test functions? You can copy and paste those lines, and then compare the resulting object to one constructed with the full array (let me know if this is unclear and I can give more guidance).

Could you also construct a test case using @shoyer 's example which fails? Again lmk if you need any guidance in how to do that.

In the final case "Use None", is that correct? Where do all the values come from? (Maybe I'm missing something basic?)

And then I think we can merge, pending any other feedback! Thanks - this will be a valuable addition to xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381
518341706 https://github.com/pydata/xarray/pull/3159#issuecomment-518341706 https://api.github.com/repos/pydata/xarray/issues/3159 MDEyOklzc3VlQ29tbWVudDUxODM0MTcwNg== max-sixty 5635139 2019-08-05T18:15:13Z 2019-08-05T18:15:13Z MEMBER

Hi @DangoMelon, no stress, I know git can be a pain.

I don't remember your previous effort so I'm not sure what the previous version looked like. Is it materially different from what currently exists? The current code looks relevant and @shoyer has reviewed & commented on it.

If you have overwritten your previous commits, you can generally get them back by using git reflog. There's plenty of documentation on that online, let us know if we can be helpful in the specific case though

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Initialize empty or full DataArray 472100381

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);