issue_comments

Table actions

2 rows where issue = 404945709 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • [WIP] Feature: Animated 1D plots · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
488732192 https://github.com/pydata/xarray/pull/2729#issuecomment-488732192 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODczMjE5Mg== dcherian 2448579 2019-05-02T16:04:06Z 2019-05-02T16:04:06Z MEMBER

This is looking great; let me know when you're ready for another review.

I recommend saving facetgrid support for future PRs. I'm personally more excited about 2D animations and am happy to implement that once all the common infrastructure is in. With that bias in mind, I think the way to proceed would be:

(this PR) → 2D animations → facetgrid support

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Feature: Animated 1D plots 404945709
488731239 https://github.com/pydata/xarray/pull/2729#issuecomment-488731239 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODczMTIzOQ== dcherian 2448579 2019-05-02T16:01:18Z 2019-05-02T16:01:18Z MEMBER

There's a glitch with the legend in the first gif. Maybe the location needs to be pinned to something that is not 'best'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Feature: Animated 1D plots 404945709

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);