home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 488732192

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2729#issuecomment-488732192 https://api.github.com/repos/pydata/xarray/issues/2729 488732192 MDEyOklzc3VlQ29tbWVudDQ4ODczMjE5Mg== 2448579 2019-05-02T16:04:06Z 2019-05-02T16:04:06Z MEMBER

This is looking great; let me know when you're ready for another review.

I recommend saving facetgrid support for future PRs. I'm personally more excited about 2D animations and am happy to implement that once all the common infrastructure is in. With that bias in mind, I think the way to proceed would be:

(this PR) → 2D animations → facetgrid support

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  404945709
Powered by Datasette · Queries took 0.866ms · About: xarray-datasette