home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

14 rows where issue = 404945709 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 8

  • TomNicholas 4
  • rabernat 2
  • dcherian 2
  • jbusecke 2
  • spencerahill 1
  • keewis 1
  • ahuang11 1
  • pep8speaks 1

author_association 3

  • MEMBER 9
  • CONTRIBUTOR 4
  • NONE 1

issue 1

  • [WIP] Feature: Animated 1D plots · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
867457793 https://github.com/pydata/xarray/pull/2729#issuecomment-867457793 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDg2NzQ1Nzc5Mw== keewis 14808389 2021-06-24T08:46:31Z 2021-06-24T08:46:31Z MEMBER

@TomNicholas, this has been unintentionally closed when renaming main. Feel free to reopen if you still plan to work on this in the future.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
656108033 https://github.com/pydata/xarray/pull/2729#issuecomment-656108033 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDY1NjEwODAzMw== TomNicholas 35968931 2020-07-09T12:50:30Z 2020-07-09T12:50:30Z MEMBER

Hi @spencerahill , sorry for the slow reply.

This functionality isn't integrated yet, but hvplot I think probably provides the better approach. You will also want to see what philipjfr came up with over on #3709 , which would allow an xarray-like syntax but with the power of holoviews.

The one remaining question for me with the holoviews approach is how easy it is to save a .gif or a video file. It seems like it might be possible already, but if you have a go then let me know how it goes! (This is something I very very much want to see working, but isn't my priority right now)

{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
639789368 https://github.com/pydata/xarray/pull/2729#issuecomment-639789368 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDYzOTc4OTM2OA== spencerahill 6200806 2020-06-05T20:28:24Z 2020-06-05T20:28:24Z CONTRIBUTOR

Just came across this PR while trying for the first time to create an animation of xarray data. Looks like it got quite far along but then sputtered. Did it get superseded by hvplot?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
489293638 https://github.com/pydata/xarray/pull/2729#issuecomment-489293638 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4OTI5MzYzOA== ahuang11 15331990 2019-05-04T04:46:34Z 2019-05-04T04:47:30Z CONTRIBUTOR

This looks awesome; it would be really nice to have built-in xarray animation support!

I'm personally more excited about 2D animations and am happy to implement that once all the common infrastructure is in.

Also wanted to point out while that's progressing along, hvplot supports 2D animations. https://hvplot.pyviz.org/ ``` import xarray as xr import hvplot.xarray import holoviews as hv hv.extension('matplotlib')

ds = xr.tutorial.open_dataset('air_temperature').isel(time=slice(0, 15)) hmap = ds.hvplot('lon', 'lat', dynamic=False).opts(fig_size=300, clim=(230, 300)) hv.save(hmap, 'anim.html', fmt='scrubber')

---

from IPython.core.display import display, HTML display(HTML('anim.html')) ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
489056485 https://github.com/pydata/xarray/pull/2729#issuecomment-489056485 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4OTA1NjQ4NQ== TomNicholas 35968931 2019-05-03T10:46:55Z 2019-05-03T10:46:55Z MEMBER

There's a glitch with the legend in the first gif. Maybe the location needs to be pinned to something that is not 'best'

Yeah, I'm not entirely sure why that happens yet, but I guess it means the legend position should be determined automatically for only the first frame, then fixed there for the other frames.

I recommend saving facetgrid support for future PRs.

Agree. I think I might also leave animated step plot support for a future PR.

I'm personally more excited about 2D animations and am happy to implement that once all the common infrastructure is in.

Help with that would be great! I also really want to get 2D animations working - I'm often trying to make animations like this:

I anticipate that there might be some difficulties with cartopy integration for 2D animations, but I don't actually use cartopy in my work, so help with that would be especially appreciated.

Just pinging jbusecke, who recently announced https://github.com/jbusecke/xmovie.

Yeah we've been talking about the relationship between this and xmovie in https://github.com/jbusecke/xmovie/issues/2. I think that movie output functionality can be tacked on later.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
488782977 https://github.com/pydata/xarray/pull/2729#issuecomment-488782977 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODc4Mjk3Nw== jbusecke 14314623 2019-05-02T18:34:55Z 2019-05-02T18:34:55Z CONTRIBUTOR

Also FYI I have a PR open that will enable xmovie to write movie files (by invoking ffmpeg 'under the hood'). Just wanted to mention it since this might come in handy as another export option for this feature later on.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
488780624 https://github.com/pydata/xarray/pull/2729#issuecomment-488780624 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODc4MDYyNA== jbusecke 14314623 2019-05-02T18:27:49Z 2019-05-02T18:27:49Z CONTRIBUTOR

This looks amazing! Which problem are you referring to specifically @rabernat?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
488734476 https://github.com/pydata/xarray/pull/2729#issuecomment-488734476 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODczNDQ3Ng== rabernat 1197350 2019-05-02T16:10:54Z 2019-05-02T16:10:54Z MEMBER

Just pinging @jbusecke, who recently announced https://github.com/jbusecke/xmovie. He might have some insights on this problem.

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
488732192 https://github.com/pydata/xarray/pull/2729#issuecomment-488732192 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODczMjE5Mg== dcherian 2448579 2019-05-02T16:04:06Z 2019-05-02T16:04:06Z MEMBER

This is looking great; let me know when you're ready for another review.

I recommend saving facetgrid support for future PRs. I'm personally more excited about 2D animations and am happy to implement that once all the common infrastructure is in. With that bias in mind, I think the way to proceed would be:

(this PR) → 2D animations → facetgrid support

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
488731239 https://github.com/pydata/xarray/pull/2729#issuecomment-488731239 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODczMTIzOQ== dcherian 2448579 2019-05-02T16:01:18Z 2019-05-02T16:01:18Z MEMBER

There's a glitch with the legend in the first gif. Maybe the location needs to be pinned to something that is not 'best'

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
459092462 https://github.com/pydata/xarray/pull/2729#issuecomment-459092462 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ1OTA5MjQ2Mg== pep8speaks 24736507 2019-01-30T20:15:59Z 2019-04-30T16:06:37Z NONE

Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-30 16:06:37 UTC
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
488005900 https://github.com/pydata/xarray/pull/2729#issuecomment-488005900 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ4ODAwNTkwMA== TomNicholas 35968931 2019-04-30T15:47:40Z 2019-04-30T15:47:40Z MEMBER

I've done some more work on this, you can now:

Plot multiple animated lines

```python dat2d = air.isel(lat=[10, 15, 20])

anim = dat2d.plot(animate='time', hue='lat') anim.save('line.gif', writer='imagemagick') plt.show() ```

Add static lines to an animated plot

```python

draw animated line

anim = dat1d.plot(animate='time', label='evolving')

draw static line

plot will be drawn on to current axes unless ax argument given

dat1d.mean(dim='time').plot(color='g', label='average')

plt.legend(loc='upper right')

anim.save('average.gif', writer='imagemagick') plt.show() ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
459368801 https://github.com/pydata/xarray/pull/2729#issuecomment-459368801 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ1OTM2ODgwMQ== TomNicholas 35968931 2019-01-31T14:42:28Z 2019-01-31T14:57:31Z MEMBER

Re complexity: It;s probably worth extracting everything to a animate_line function in animate.py?

I've had a go at that in the most recent commits.

I think this is a cool example, and lots of users will probably like it.

Great - it's definitely something I personally want to do all the time.

A high-level question: why was animatplot chosen over matplotlib's animation module?

Because animatplot already abstracts away the creation of the animation, so plotting an animation becomes almost a simple substitution matplotlib.plot.line() -> animatplot.blocks.Line().

Another advantage is that animatplot's block abstraction should make it easier to compose figures made of multiple animated plots, another thing people often want to do but is is awful with matplotlib.funcanimation directly.

(I haven't really looked at how animated facetgrids might work yet, but I suspect that being able to animate a large list of blocks would be helpful too.)

The logic is explained slightly more in #2355, and also looking at animatplot's docs might help you see why I think it's a good idea.

We don't have to use animatplot, but if we didn't I would be suggesting reimplementing something with a similar class structure in xarray as the best approach anyway. The disadvantages of using animatplot are that it's an extra (optional) dependency, and it's not got good unit test coverage yet so someone should probably contribute tests to animatplot upstream before xarray officially relies on it. animatplot isn't particularly large, so if we wanted to reimplement something similar in xarray then that would be feasible.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709
459358900 https://github.com/pydata/xarray/pull/2729#issuecomment-459358900 https://api.github.com/repos/pydata/xarray/issues/2729 MDEyOklzc3VlQ29tbWVudDQ1OTM1ODkwMA== rabernat 1197350 2019-01-31T14:14:38Z 2019-01-31T14:14:38Z MEMBER

I think this is a cool example, and lots of users will probably like it.

A high-level question: why was animatplot chosen over matplotlib's animation module?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  [WIP] Feature: Animated 1D plots 404945709

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 18.708ms · About: xarray-datasette