issue_comments

Table actions

4 rows where issue = 391865060 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 4 ✖

issue 1

  • API for N-dimensional combine · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
493829782 https://github.com/pydata/xarray/pull/2616#issuecomment-493829782 https://api.github.com/repos/pydata/xarray/issues/2616 MDEyOklzc3VlQ29tbWVudDQ5MzgyOTc4Mg== dcherian 2448579 2019-05-20T03:46:44Z 2019-05-20T03:46:44Z MEMBER

Thanks @TomNicholas. You can use @pytest.mark.filterwarnings to filter specific warnings. I think that's what the decorator is called anyway. There are places where it's used in the testing code so you have plenty of examples to copy from.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   API for N-dimensional combine 391865060
481900732 https://github.com/pydata/xarray/pull/2616#issuecomment-481900732 https://api.github.com/repos/pydata/xarray/issues/2616 MDEyOklzc3VlQ29tbWVudDQ4MTkwMDczMg== dcherian 2448579 2019-04-10T23:08:47Z 2019-04-10T23:08:47Z MEMBER

@dcherian the relevant docstrings have been significantly altered, including giving some examples.

Yes I saw that but missed https://github.com/pydata/xarray/blob/513764fa4094acda67aec5fea8397bc5726afb90/xarray/core/combine.py#L307

However I haven't changed any of the main documentation pages, I guess I should look through to see if this will change any of the syntax in any of those examples.

Or are you suggesting there should be a new section of the documentation explaining what the difference between combine_manual and combine_auto is?

Yes, I think you can add the examples from the docstrings to https://xarray.pydata.org/en/stable/combining.html since that's where users will look for such functionality.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   API for N-dimensional combine 391865060
481898359 https://github.com/pydata/xarray/pull/2616#issuecomment-481898359 https://api.github.com/repos/pydata/xarray/issues/2616 MDEyOklzc3VlQ29tbWVudDQ4MTg5ODM1OQ== dcherian 2448579 2019-04-10T22:57:49Z 2019-04-10T22:57:49Z MEMBER

I haven't reviewed the PR but noticed that there's no documentation to go along with it. Is that intentional?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   API for N-dimensional combine 391865060
470114401 https://github.com/pydata/xarray/pull/2616#issuecomment-470114401 https://api.github.com/repos/pydata/xarray/issues/2616 MDEyOklzc3VlQ29tbWVudDQ3MDExNDQwMQ== dcherian 2448579 2019-03-06T13:51:47Z 2019-03-06T13:51:47Z MEMBER

+1 for switching to combine_auto, combine_manual but not having both auto_combine and combine_auto.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   API for N-dimensional combine 391865060

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);