issue_comments: 481900732

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2616#issuecomment-481900732 https://api.github.com/repos/pydata/xarray/issues/2616 481900732 MDEyOklzc3VlQ29tbWVudDQ4MTkwMDczMg== 2448579 2019-04-10T23:08:47Z 2019-04-10T23:08:47Z MEMBER

@dcherian the relevant docstrings have been significantly altered, including giving some examples.

Yes I saw that but missed https://github.com/pydata/xarray/blob/513764fa4094acda67aec5fea8397bc5726afb90/xarray/core/combine.py#L307

However I haven't changed any of the main documentation pages, I guess I should look through to see if this will change any of the syntax in any of those examples.

Or are you suggesting there should be a new section of the documentation explaining what the difference between combine_manual and combine_auto is?

Yes, I think you can add the examples from the docstrings to https://xarray.pydata.org/en/stable/combining.html since that's where users will look for such functionality.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   391865060