issues: 391865060

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
391865060 MDExOlB1bGxSZXF1ZXN0MjM5MjYzOTU5 2616 API for N-dimensional combine 35968931 closed 0     25 2018-12-17T19:51:32Z 2019-06-25T16:18:29Z 2019-06-25T15:14:34Z MEMBER   0 pydata/xarray/pulls/2616

Continues the discussion from #2553 about how the API for loading and combining data from multiple datasets should work. (Ultimately part of the solution to #2159)

@shoyer this is for you to see how I envisaged the API would look, based on our discussion in #2553. For now you can ignore all the changes except the ones to the docstrings of auto_combine here, manual_combine here and open_mfdataset here.

Feedback from anyone else is also encouraged, as really the point of this is to make the API as clear as possible to someone who hasn't delved into the code behind auto_combine and open_mfdataset.

It makes sense to first work out the API, then change the internal implementation to match, using the internal functions developed in #2553. Therefore the tasks include:

  • [x] Decide on API for 'auto_combine' and 'open_mfdataset'
  • [x] Appropriate documentation
  • [x] Write internal implementation of manual_combine
  • [x] Write internal implementation of auto-combine
  • [x] Update open_mfdataset to match
  • [x] Write and reorganise tests
  • [x] Automatically ordering of string and datetime coords
  • [x] What's new explaining changes
  • [x] Make sure auto_combine and manual_combine appear on the API page of the docs
  • [x] PEP8 compliance
  • [x] Python 3.5 compatibility
  • [x] AirSpeedVelocity tests for auto_combine
  • [x] Finish all TODOs
  • [x] Backwards-compatible API to start deprecation cycle
  • [x] Add examples from docstrings to main documentation pages
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2616/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables