issue_comments

Table actions

2 rows where issue = 269996138 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 2 ✖

issue 1

  • Support orthogonal indexing in MemoryCachedArray (Fix for #1429) · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
341999483 https://github.com/pydata/xarray/pull/1676#issuecomment-341999483 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MTk5OTQ4Mw== fmaussion 10050469 2017-11-05T19:46:06Z 2017-11-05T19:46:06Z MEMBER

Is there any need to add indexing tests for rasterio backend, after this issue #1429 is resolved?

No, I don't think so. Thanks!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
341370145 https://github.com/pydata/xarray/pull/1676#issuecomment-341370145 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MTM3MDE0NQ== fmaussion 10050469 2017-11-02T09:52:22Z 2017-11-02T11:00:22Z MEMBER

@fmaussion How did you notice issue #1429? I found test_backends.py already checked the orthogonal indexing. I guess there are some untested use cases.

I don't remember exactly, but it happened when I wrote tests for rasterio's indexing: https://github.com/pydata/xarray/blob/master/xarray/tests/test_backends.py#L1855-L1884 (I just tested all possible combinations of index operations I could think of).

The caching mechanism has some non-intuitive consequences, for example that some indexing operations not allowed on a rasterio file stored on disk become available once the data is cached: https://github.com/pydata/xarray/blob/master/xarray/tests/test_backends.py#L1916-L1927

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);