issue_comments

Table actions

7 rows where issue = 269996138 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Support orthogonal indexing in MemoryCachedArray (Fix for #1429) · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
342221175 https://github.com/pydata/xarray/pull/1676#issuecomment-342221175 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MjIyMTE3NQ== shoyer 1217238 2017-11-06T17:22:05Z 2017-11-06T17:22:05Z MEMBER

Thanks again @fujiisoup !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
342002124 https://github.com/pydata/xarray/pull/1676#issuecomment-342002124 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MjAwMjEyNA== shoyer 1217238 2017-11-05T20:20:58Z 2017-11-05T20:20:58Z MEMBER

I renamed SUPPORT_ARRAY_TYPES to NON_NUMPY_SUPPORTED_ARRAY_TYPES which is longer but more obvious in its meaning. I think this is good to go in now.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
341999483 https://github.com/pydata/xarray/pull/1676#issuecomment-341999483 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MTk5OTQ4Mw== fmaussion 10050469 2017-11-05T19:46:06Z 2017-11-05T19:46:06Z MEMBER

Is there any need to add indexing tests for rasterio backend, after this issue #1429 is resolved?

No, I don't think so. Thanks!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
341942162 https://github.com/pydata/xarray/pull/1676#issuecomment-341942162 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MTk0MjE2Mg== fujiisoup 6815844 2017-11-05T01:23:52Z 2017-11-05T01:23:52Z MEMBER

@fmaussion Thanks for the information. Is there any need to add indexing tests for rasterio backend, after this issue #1429 is resolved? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
341370145 https://github.com/pydata/xarray/pull/1676#issuecomment-341370145 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MTM3MDE0NQ== fmaussion 10050469 2017-11-02T09:52:22Z 2017-11-02T11:00:22Z MEMBER

@fmaussion How did you notice issue #1429? I found test_backends.py already checked the orthogonal indexing. I guess there are some untested use cases.

I don't remember exactly, but it happened when I wrote tests for rasterio's indexing: https://github.com/pydata/xarray/blob/master/xarray/tests/test_backends.py#L1855-L1884 (I just tested all possible combinations of index operations I could think of).

The caching mechanism has some non-intuitive consequences, for example that some indexing operations not allowed on a rasterio file stored on disk become available once the data is cached: https://github.com/pydata/xarray/blob/master/xarray/tests/test_backends.py#L1916-L1927

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
341301249 https://github.com/pydata/xarray/pull/1676#issuecomment-341301249 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MTMwMTI0OQ== shoyer 1217238 2017-11-02T02:39:51Z 2017-11-02T02:39:51Z MEMBER

Also, I should say: thank you again for diving into the internals here. This sort of clean-up work is extremely important, even though it isn't as visible as new features.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138
340940369 https://github.com/pydata/xarray/pull/1676#issuecomment-340940369 https://api.github.com/repos/pydata/xarray/issues/1676 MDEyOklzc3VlQ29tbWVudDM0MDk0MDM2OQ== fujiisoup 6815844 2017-10-31T23:52:00Z 2017-10-31T23:52:00Z MEMBER

@fmaussion How did you notice issue #1429? I found test_backends.py already checked the orthogonal indexing.

I guess there are some untested use cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 269996138

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);