issues: 269996138

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
269996138 MDExOlB1bGxSZXF1ZXN0MTQ5ODE0MTU2 1676 Support orthogonal indexing in MemoryCachedArray (Fix for #1429) 6815844 closed 0     7 2017-10-31T15:10:59Z 2017-11-09T13:47:38Z 2017-11-06T17:21:56Z MEMBER   0 pydata/xarray/pulls/1676
  • [x] Closes #1429
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master **/*py | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

This bug originates from the complicated structure around the array wrappers and their indexing, i.e. different array wrappers support different indexing types, and moreover, some can store another array wrapper in it.

I made some cleanups. + Now every array wrapper is a subclass of NDArrayIndexable + Every array wrapper should implement its own __getitem__ or just store another NDArrayIndexable.

I think I added enough test for it, but I am not yet fully accustomed with xarray's backend. There might be many combinations of their hierarchical relation.

I would appreciate any comments.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1676/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables