issue_comments

Table actions

11 rows where issue = 192752746 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: body, created_at (date), updated_at (date)

user 1

  • max-sixty · 11 ✖

issue 1

  • Pytest assert functions · 11 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
268868297 https://github.com/pydata/xarray/pull/1147#issuecomment-268868297 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2ODg2ODI5Nw== max-sixty 5635139 2016-12-22T19:07:08Z 2016-12-22T19:07:08Z MEMBER

@shoyer green!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
268715495 https://github.com/pydata/xarray/pull/1147#issuecomment-268715495 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2ODcxNTQ5NQ== max-sixty 5635139 2016-12-22T04:23:49Z 2016-12-22T04:23:49Z MEMBER

@shoyer green!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
268587349 https://github.com/pydata/xarray/pull/1147#issuecomment-268587349 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2ODU4NzM0OQ== max-sixty 5635139 2016-12-21T17:35:16Z 2016-12-21T17:35:16Z MEMBER

@fmaussion had a go - is that what you were thinking?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
268435788 https://github.com/pydata/xarray/pull/1147#issuecomment-268435788 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2ODQzNTc4OA== max-sixty 5635139 2016-12-21T04:59:30Z 2016-12-21T04:59:30Z MEMBER

Rebased on https://github.com/pydata/xarray/pull/1175, so that should be merged first if people agree

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
268410195 https://github.com/pydata/xarray/pull/1147#issuecomment-268410195 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2ODQxMDE5NQ== max-sixty 5635139 2016-12-21T01:37:30Z 2016-12-21T01:38:31Z MEMBER

@shoyer I fixed most of the tests. Will come back and check the remaining few failures

I didn't quite realize how many .assertVariable... tests were relying on coercion, so I ended up changing the tests in a lot of places. The test is explicit at the test site, at least.

There were a couple that I think are probably breaks - things like .argsort changing the type of a Variable. I marked those with comments but haven't fixed them - or we'll never get this in! Let me know if you have thoughts on any notes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
267456077 https://github.com/pydata/xarray/pull/1147#issuecomment-267456077 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzQ1NjA3Nw== max-sixty 5635139 2016-12-15T21:56:50Z 2016-12-15T21:56:50Z MEMBER

There are more than a dozen: https://travis-ci.org/pydata/xarray/jobs/184356287#L2611

Also some binary / unicode errors - let me know if you have context

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
267439370 https://github.com/pydata/xarray/pull/1147#issuecomment-267439370 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzQzOTM3MA== max-sixty 5635139 2016-12-15T20:46:23Z 2016-12-15T20:46:23Z MEMBER

@shoyer do you have ideas for when the types are not the same? For example, many of the tests compare Variable to IndexVariable. Should we not check types? Add a check_type=True argument to the testing functions? Change the tests so they're compliant?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
267234900 https://github.com/pydata/xarray/pull/1147#issuecomment-267234900 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzIzNDkwMA== max-sixty 5635139 2016-12-15T04:17:44Z 2016-12-15T04:17:44Z MEMBER

The last thing I would do is switch the existing test methods like assertDatasetEqual to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).

All of tests? I think that's a fairly heavy lift for this PR. It also happens to be really tedious and unfortunately I don't think Find / Replace-able... If you feel strongly I'll plug in and go through though!

Otherwise we can roll out over time as people write new tests

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
266570819 https://github.com/pydata/xarray/pull/1147#issuecomment-266570819 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NjU3MDgxOQ== max-sixty 5635139 2016-12-12T22:17:28Z 2016-12-12T22:17:28Z MEMBER

@shoyer green

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
265805479 https://github.com/pydata/xarray/pull/1147#issuecomment-265805479 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NTgwNTQ3OQ== max-sixty 5635139 2016-12-08T17:46:37Z 2016-12-09T02:05:16Z MEMBER

Thanks for the feedback! Updated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
264573054 https://github.com/pydata/xarray/pull/1147#issuecomment-264573054 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NDU3MzA1NA== max-sixty 5635139 2016-12-02T21:55:47Z 2016-12-02T21:55:47Z MEMBER

Updated.

Is it worth 'testing the tests'? I couldn't find tests for the existing functions

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);