home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 268410195

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1147#issuecomment-268410195 https://api.github.com/repos/pydata/xarray/issues/1147 268410195 MDEyOklzc3VlQ29tbWVudDI2ODQxMDE5NQ== 5635139 2016-12-21T01:37:30Z 2016-12-21T01:38:31Z MEMBER

@shoyer I fixed most of the tests. Will come back and check the remaining few failures

I didn't quite realize how many .assertVariable... tests were relying on coercion, so I ended up changing the tests in a lot of places. The test is explicit at the test site, at least.

There were a couple that I think are probably breaks - things like .argsort changing the type of a Variable. I marked those with comments but haven't fixed them - or we'll never get this in! Let me know if you have thoughts on any notes

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  192752746
Powered by Datasette · Queries took 79.475ms · About: xarray-datasette