home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 267234900

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1147#issuecomment-267234900 https://api.github.com/repos/pydata/xarray/issues/1147 267234900 MDEyOklzc3VlQ29tbWVudDI2NzIzNDkwMA== 5635139 2016-12-15T04:17:44Z 2016-12-15T04:17:44Z MEMBER

The last thing I would do is switch the existing test methods like assertDatasetEqual to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).

All of tests? I think that's a fairly heavy lift for this PR. It also happens to be really tedious and unfortunately I don't think Find / Replace-able... If you feel strongly I'll plug in and go through though!

Otherwise we can roll out over time as people write new tests

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  192752746
Powered by Datasette · Queries took 78.521ms · About: xarray-datasette