issues: 192752746

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
192752746 MDExOlB1bGxSZXF1ZXN0OTYwMjUwMTk= 1147 Pytest assert functions 5635139 closed 0     20 2016-12-01T04:36:56Z 2016-12-22T19:20:08Z 2016-12-22T19:20:08Z MEMBER   0 pydata/xarray/pulls/1147

Is this a reasonable function to use with py.test? In place of the inheritance .assertVariableEqual etc.

  • Do we want separate functions for each class?
  • There's a comment or just switch to py.test and add an appropriate hook. - is that different to what's here?
  • This still needs to be completed, with additional functions for assert _identical and assert_approx_equal.
  • Do we want more description for the failure, above just printing the arguments? That can also be added later
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1147/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables