issue_comments

Table actions

5 rows where issue = 192752746 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Pytest assert functions · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
267440249 https://github.com/pydata/xarray/pull/1147#issuecomment-267440249 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzQ0MDI0OQ== shoyer 1217238 2016-12-15T20:50:17Z 2016-12-15T20:50:17Z MEMBER

In most cases I would guess these are broken tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
267237757 https://github.com/pydata/xarray/pull/1147#issuecomment-267237757 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzIzNzc1Nw== shoyer 1217238 2016-12-15T04:45:17Z 2016-12-15T04:45:17Z MEMBER

You might also add these to the API docs page and what's new. I know there has been interest in public test functions for quite some time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
267236307 https://github.com/pydata/xarray/pull/1147#issuecomment-267236307 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzIzNjMwNw== shoyer 1217238 2016-12-15T04:30:50Z 2016-12-15T04:30:50Z MEMBER

No no no... Just the definitions of the methods like assertDatasetEqual on the bass xarray TestCase class, which you can now define as aliases to your new functions. On Wed, Dec 14, 2016 at 8:17 PM Maximilian Roos notifications@github.com wrote:

The last thing I would do is switch the existing test methods like assertDatasetEqual to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).

All of tests? I think that's a fairly heavy lift for this PR. It also happens to be really tedious and unfortunately I don't think Find / Replace-able... If you feel strongly I'll plug in and go through though!

Otherwise we can roll out over time as people write new tests

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1147#issuecomment-267234900, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1hhpkMSPNJZ4mPZ-ncrUwRBuYVfeks5rIL9ogaJpZM4LA_ql . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
267216755 https://github.com/pydata/xarray/pull/1147#issuecomment-267216755 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NzIxNjc1NQ== shoyer 1217238 2016-12-15T02:10:53Z 2016-12-15T02:10:53Z MEMBER

This looks good to me. The last thing I would do is switch the existing test methods like assertDatasetEqual to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746
264369143 https://github.com/pydata/xarray/pull/1147#issuecomment-264369143 https://api.github.com/repos/pydata/xarray/issues/1147 MDEyOklzc3VlQ29tbWVudDI2NDM2OTE0Mw== shoyer 1217238 2016-12-02T04:11:06Z 2016-12-02T04:11:06Z MEMBER

Do we want separate functions for each class?

That seems like overkill -- I think one is fine.

There's a comment or just switch to py.test and add an appropriate hook. - is that different to what's here?

I was thinking of something like how python lets you override the message for assert a == b. But it actually looks like there is no suitable hook for custom explanations when using methods. __traceback__ = False, like you do here, is about the best you can do.

Do we want more description for the failure, above just printing the arguments? That can also be added later

It's nice to at least print the objects on separate lines, e.g., using something like '%r\n%r' % (a, b) for the assert message. Otherwise multi-line reprs end up with the start of the second object on the same line as the first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pytest assert functions 192752746

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);