issue_comments: 264369143

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1147#issuecomment-264369143 https://api.github.com/repos/pydata/xarray/issues/1147 264369143 MDEyOklzc3VlQ29tbWVudDI2NDM2OTE0Mw== 1217238 2016-12-02T04:11:06Z 2016-12-02T04:11:06Z MEMBER

Do we want separate functions for each class?

That seems like overkill -- I think one is fine.

There's a comment or just switch to py.test and add an appropriate hook. - is that different to what's here?

I was thinking of something like how python lets you override the message for assert a == b. But it actually looks like there is no suitable hook for custom explanations when using methods. __traceback__ = False, like you do here, is about the best you can do.

Do we want more description for the failure, above just printing the arguments? That can also be added later

It's nice to at least print the objects on separate lines, e.g., using something like '%r\n%r' % (a, b) for the assert message. Otherwise multi-line reprs end up with the start of the second object on the same line as the first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   192752746