issue_comments: 267236307

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1147#issuecomment-267236307 https://api.github.com/repos/pydata/xarray/issues/1147 267236307 MDEyOklzc3VlQ29tbWVudDI2NzIzNjMwNw== 1217238 2016-12-15T04:30:50Z 2016-12-15T04:30:50Z MEMBER

No no no... Just the definitions of the methods like assertDatasetEqual on the bass xarray TestCase class, which you can now define as aliases to your new functions. On Wed, Dec 14, 2016 at 8:17 PM Maximilian Roos notifications@github.com wrote:

The last thing I would do is switch the existing test methods like assertDatasetEqual to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).

All of tests? I think that's a fairly heavy lift for this PR. It also happens to be really tedious and unfortunately I don't think Find / Replace-able... If you feel strongly I'll plug in and go through though!

Otherwise we can roll out over time as people write new tests

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1147#issuecomment-267234900, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1hhpkMSPNJZ4mPZ-ncrUwRBuYVfeks5rIL9ogaJpZM4LA_ql . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   192752746