home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

2 rows where issue = 1345644028 and user = 302469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • QuLogic · 2 ✖

issue 1

  • ⚠️ Nightly upstream-dev CI failed ⚠️ · 2 ✖

author_association 1

  • CONTRIBUTOR 2
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1233350295 https://github.com/pydata/xarray/issues/6941#issuecomment-1233350295 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85Jg26X QuLogic 302469 2022-08-31T19:44:24Z 2022-08-31T19:44:24Z CONTRIBUTOR

IIUC, I think this is the exception those tests are trying to check: https://github.com/pydata/xarray/blob/4880012ddee9e43e3e18e95551876e9c182feafb/xarray/plot/utils.py#L893-L896

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028
1233345322 https://github.com/pydata/xarray/issues/6941#issuecomment-1233345322 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85Jg1sq QuLogic 302469 2022-08-31T19:38:24Z 2022-08-31T19:38:24Z CONTRIBUTOR

We looked at this downstream in Matplotlib to see if we introduced something in 3.6.0rc2. There was a bug there in that exception types changed unexpectedly.

However, I am thinking that these two tests are incorrect. They are generically checking for ValueError without a match on the exception text. This means they completely missed the fact that husl was an invalid colormap (which was only exposed because 3.6.0rc2 accidentally changed the type for that exception), whereas I think it was only supposed to check that levels was not specified.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 12.894ms · About: xarray-datasette