issue_comments

Table actions

5 rows where issue = 1345644028 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • ⚠️ Nightly upstream-dev CI failed ⚠️ · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1274969028 https://github.com/pydata/xarray/issues/6941#issuecomment-1274969028 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85L_nvE dcherian 2448579 2022-10-11T16:31:46Z 2022-10-11T16:31:46Z MEMBER

Closing since our action keeps updating the message and the discussion isn't relevant any more.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028
1263288581 https://github.com/pydata/xarray/issues/6941#issuecomment-1263288581 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85LTEEF rhkleijn 32801740 2022-09-30T08:43:47Z 2022-09-30T08:50:06Z CONTRIBUTOR

The last run reports (development) version 2022.9.1.dev3+g341f1302 of xarray (derived from the most recent tag 2022.9.0).

I assume you have seen version 0.18.x in your personal fork. I have seen similar problems where version 0.16.x of xarray was shown. The culprit seems to be that the github button for syncing your fork with the upstream repo doesn't update tags. It only contains the tags from back when you created the fork. I updated the tags manually using something like git fetch --tags upstream git push --tags origin which did the trick for me.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028
1263157424 https://github.com/pydata/xarray/issues/6941#issuecomment-1263157424 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85LSkCw headtr1ck 43316012 2022-09-30T06:24:43Z 2022-09-30T06:24:43Z COLLABORATOR

The current failures are because the installed xarray seems to have version 0.18.x and pandas requires >= 0.19

Is that a bug in setuptools?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028
1233350295 https://github.com/pydata/xarray/issues/6941#issuecomment-1233350295 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85Jg26X QuLogic 302469 2022-08-31T19:44:24Z 2022-08-31T19:44:24Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028
1233345322 https://github.com/pydata/xarray/issues/6941#issuecomment-1233345322 https://api.github.com/repos/pydata/xarray/issues/6941 IC_kwDOAMm_X85Jg1sq QuLogic 302469 2022-08-31T19:38:24Z 2022-08-31T19:38:24Z CONTRIBUTOR

We looked at this downstream in Matplotlib to see if we introduced something in 3.6.0rc2. There was a bug there in that exception types changed unexpectedly.

However, I am thinking that these two tests are incorrect. They are generically checking for ValueError without a match on the exception text. This means they completely missed the fact that husl was an invalid colormap (which was only exposed because 3.6.0rc2 accidentally changed the type for that exception), whereas I think it was only supposed to check that levels was not specified.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️ 1345644028

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);