issue_comments: 1233345322

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6941#issuecomment-1233345322 https://api.github.com/repos/pydata/xarray/issues/6941 1233345322 IC_kwDOAMm_X85Jg1sq 302469 2022-08-31T19:38:24Z 2022-08-31T19:38:24Z CONTRIBUTOR

We looked at this downstream in Matplotlib to see if we introduced something in 3.6.0rc2. There was a bug there in that exception types changed unexpectedly.

However, I am thinking that these two tests are incorrect. They are generically checking for ValueError without a match on the exception text. This means they completely missed the fact that husl was an invalid colormap (which was only exposed because 3.6.0rc2 accidentally changed the type for that exception), whereas I think it was only supposed to check that levels was not specified.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1345644028