issue_comments
30 rows where author_association = "NONE", issue = 525685973 and user = 45787861 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- cov() and corr() - finalization · 30 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
557895005 | https://github.com/pydata/xarray/pull/3550#issuecomment-557895005 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzg5NTAwNQ== | r-beer 45787861 | 2019-11-24T14:41:44Z | 2019-11-24T14:41:44Z | NONE | I have added several test cases, almost all pass. The ones that don't pass are related to I had a look at
I actually prefer the numpy behavior, resulting in covariance and correlation matrices. However I feel that efficient implementation of this behavior is above my current understanding of xarray. So, I would highly appreciate your support on this implementation! Otherwise, I added the |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557874527 | https://github.com/pydata/xarray/pull/3550#issuecomment-557874527 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzg3NDUyNw== | r-beer 45787861 | 2019-11-24T10:11:31Z | 2019-11-24T10:15:19Z | NONE |
On the one side, I am with you in terms of "What You Put In Is What You Get Out", on the other hand


So for the moment, we might stick with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557872510 | https://github.com/pydata/xarray/pull/3550#issuecomment-557872510 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzg3MjUxMA== | r-beer 45787861 | 2019-11-24T09:39:30Z | 2019-11-24T09:39:30Z | NONE |
Alright! I found myself having very similar tests and therefore abstracted it to test_func. I completely agree with not abstracting too early and but when having the same structure several times. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557829302 | https://github.com/pydata/xarray/pull/3550#issuecomment-557829302 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NzgyOTMwMg== | r-beer 45787861 | 2019-11-23T20:13:45Z | 2019-11-23T20:13:45Z | NONE |
Maybe, as a first step some type checking would be enough, to identify such special cases as the one above and give a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557828920 | https://github.com/pydata/xarray/pull/3550#issuecomment-557828920 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NzgyODkyMA== | r-beer 45787861 | 2019-11-23T20:07:56Z | 2019-11-23T20:08:11Z | NONE |
Yes, I will add it. Thinking about test arrays in general:
Wouldn't it be good to define some data array fixtures in the In view of the additional test I started to restructure the Any guidelines or suggestions? Either way, it would be good to have a clear list of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557812486 | https://github.com/pydata/xarray/pull/3550#issuecomment-557812486 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NzgxMjQ4Ng== | r-beer 45787861 | 2019-11-23T16:33:58Z | 2019-11-23T16:34:39Z | NONE | Turns out the
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557790321 | https://github.com/pydata/xarray/pull/3550#issuecomment-557790321 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzc5MDMyMQ== | r-beer 45787861 | 2019-11-23T11:34:12Z | 2019-11-23T11:34:12Z | NONE |
Further PRs:
|
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557787104 | https://github.com/pydata/xarray/pull/3550#issuecomment-557787104 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzc4NzEwNA== | r-beer 45787861 | 2019-11-23T10:45:17Z | 2019-11-23T10:45:17Z | NONE | @dcherian, @max-sixty, @keewis, @Hoeze, second try: any more improvements required? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557781732 | https://github.com/pydata/xarray/pull/3550#issuecomment-557781732 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzc4MTczMg== | r-beer 45787861 | 2019-11-23T09:23:46Z | 2019-11-23T09:23:46Z | NONE |
Now, I additionally get errors from pre-commit claiming that Guess, the pre-commit installation was not completely correct? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557777317 | https://github.com/pydata/xarray/pull/3550#issuecomment-557777317 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Nzc3NzMxNw== | r-beer 45787861 | 2019-11-23T08:08:44Z | 2019-11-23T08:08:44Z | NONE |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557706382 | https://github.com/pydata/xarray/pull/3550#issuecomment-557706382 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NzcwNjM4Mg== | r-beer 45787861 | 2019-11-22T21:46:25Z | 2019-11-22T21:46:25Z | NONE | PS: I personally would like to use cov and corr also with dask. Does it also make sense to put this in a future PR, together with the above-mentioned other improvements? Further PRs:
- Add
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557701008 | https://github.com/pydata/xarray/pull/3550#issuecomment-557701008 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NzcwMTAwOA== | r-beer 45787861 | 2019-11-22T21:27:59Z | 2019-11-22T21:27:59Z | NONE | @dcherian, @max-sixty, @keewis, @Hoeze, this is it, is it? Let me know if there are some adjustments to be made. 🙂 And I still get |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
557085576 | https://github.com/pydata/xarray/pull/3550#issuecomment-557085576 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NzA4NTU3Ng== | r-beer 45787861 | 2019-11-21T13:31:19Z | 2019-11-21T13:31:19Z | NONE |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556991085 | https://github.com/pydata/xarray/pull/3550#issuecomment-556991085 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Njk5MTA4NQ== | r-beer 45787861 | 2019-11-21T09:14:20Z | 2019-11-21T09:14:20Z | NONE | PS: accidently closed and commented instead of commenting |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556990852 | https://github.com/pydata/xarray/pull/3550#issuecomment-556990852 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1Njk5MDg1Mg== | r-beer 45787861 | 2019-11-21T09:13:44Z | 2019-11-21T09:14:04Z | NONE |
@shoyer, @max-sixty, @keewis, where should these functions be placed? my first guesses: - computation - dataarray |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556517301 | https://github.com/pydata/xarray/pull/3550#issuecomment-556517301 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjUxNzMwMQ== | r-beer 45787861 | 2019-11-20T22:58:16Z | 2019-11-20T22:58:16Z | NONE |
I think it already gives a good overview, but then it might be unclear how to proceed. Maybe it might make sense to add a subsection
|
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556507107 | https://github.com/pydata/xarray/pull/3550#issuecomment-556507107 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjUwNzEwNw== | r-beer 45787861 | 2019-11-20T22:48:25Z | 2019-11-20T22:48:25Z | NONE | For the sake of completeness (and to already learn the procedure) I just added some information to I would be happy for feedback! Tomorrow, I will rewrite the methods to functions and go through all the steps again. Good night from Germany! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556492992 | https://github.com/pydata/xarray/pull/3550#issuecomment-556492992 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjQ5Mjk5Mg== | r-beer 45787861 | 2019-11-20T22:34:58Z | 2019-11-20T22:34:58Z | NONE |
Sure! I actually asked myself a similar software design question in another project. Shouldn't be too much effort I guess? I will tackle it tomorrow. 😴 |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556490349 | https://github.com/pydata/xarray/pull/3550#issuecomment-556490349 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjQ5MDM0OQ== | r-beer 45787861 | 2019-11-20T22:32:28Z | 2019-11-20T22:32:28Z | NONE |
Oh, ok. I thought I have to create |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556473132 | https://github.com/pydata/xarray/pull/3550#issuecomment-556473132 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjQ3MzEzMg== | r-beer 45787861 | 2019-11-20T22:16:24Z | 2019-11-20T22:16:24Z | NONE |
Alright! I am now looking into the generation of the documentation. However, it seems like the contributing guidelines are not up-to-date, as it's not possible to create the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556404945 | https://github.com/pydata/xarray/pull/3550#issuecomment-556404945 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjQwNDk0NQ== | r-beer 45787861 | 2019-11-20T21:14:22Z | 2019-11-20T21:14:22Z | NONE |
I have tried to wrap my head around the elegant use of fixtures and parametrize but didn't get there yet. If you have some time to show a more elegant solution, I would be happy to learn! If not, I guess this should work, too. Are the examples OK like this? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556265324 | https://github.com/pydata/xarray/pull/3550#issuecomment-556265324 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjI2NTMyNA== | r-beer 45787861 | 2019-11-20T19:13:20Z | 2019-11-20T19:13:20Z | NONE |
OK! That simplifies the tasks quite a bit 🙂 I will implement this and the special cases for the tests, I might add Jupyter Notebook examples later to the documentation, when the |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556248781 | https://github.com/pydata/xarray/pull/3550#issuecomment-556248781 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjI0ODc4MQ== | r-beer 45787861 | 2019-11-20T18:59:08Z | 2019-11-20T18:59:08Z | NONE |
@max-sixty, I have found the |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556244906 | https://github.com/pydata/xarray/pull/3550#issuecomment-556244906 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjI0NDkwNg== | r-beer 45787861 | 2019-11-20T18:55:57Z | 2019-11-20T18:55:57Z | NONE | Concerning the examples, I have started to create a I have seen that the existing examples contain html code. Why is that? Why not only markdown? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556094542 | https://github.com/pydata/xarray/pull/3550#issuecomment-556094542 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjA5NDU0Mg== | r-beer 45787861 | 2019-11-20T16:48:16Z | 2019-11-20T16:48:55Z | NONE |
@max-sixty, do you mean to add a TODO to the function mentioned in this commit: https://github.com/pydata/xarray/pull/3550/commits/d57eb7cfaf1407179080f0ca95e7951e5622b493? Here, I think the |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556050094 | https://github.com/pydata/xarray/pull/3550#issuecomment-556050094 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjA1MDA5NA== | r-beer 45787861 | 2019-11-20T15:19:16Z | 2019-11-20T15:19:16Z | NONE |
Thank you two, @max-sixty and @keewis, for the constructive feedback that made the start easier! I would also be happy to go once through the whole process and then implement the PR for the ds separately. This will probably cut the learning curve and accelerate the process. Additionally, I wonder whether I have to configure black for the spaces between colons? I had autoformatting running with autopep8 previously but since one of the last VS code updates something broke so I will set this up properly again on Friday or tomorrow. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
556010240 | https://github.com/pydata/xarray/pull/3550#issuecomment-556010240 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NjAxMDI0MA== | r-beer 45787861 | 2019-11-20T13:47:24Z | 2019-11-20T13:47:24Z | NONE |
Yes, the functionality that I would be very interested in would be to calculate |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
555999418 | https://github.com/pydata/xarray/pull/3550#issuecomment-555999418 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NTk5OTQxOA== | r-beer 45787861 | 2019-11-20T13:17:37Z | 2019-11-20T13:17:37Z | NONE |
OK, no need for the extra effort at this point, the squashing at the end of PR is fine for me. Thank you for the offer, anyway! 🙂 Are any other changes necessary for the PR? ideas: - examples for corr and cov usage - whats-new.rst |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
555995427 | https://github.com/pydata/xarray/pull/3550#issuecomment-555995427 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NTk5NTQyNw== | r-beer 45787861 | 2019-11-20T13:06:32Z | 2019-11-20T13:06:32Z | NONE |
Dear @keewis, I just set my real email address also as public email address and set my local git user name and email address accordingly. Does this solve the problem? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 | |
555966566 | https://github.com/pydata/xarray/pull/3550#issuecomment-555966566 | https://api.github.com/repos/pydata/xarray/issues/3550 | MDEyOklzc3VlQ29tbWVudDU1NTk2NjU2Ng== | r-beer 45787861 | 2019-11-20T11:39:11Z | 2019-11-20T11:39:11Z | NONE | @max-sixty, all three checks fail because Shall I, therefore, add the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
cov() and corr() - finalization 525685973 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 1