issue_comments: 556094542

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3550#issuecomment-556094542 https://api.github.com/repos/pydata/xarray/issues/3550 556094542 MDEyOklzc3VlQ29tbWVudDU1NjA5NDU0Mg== 45787861 2019-11-20T16:48:16Z 2019-11-20T16:48:55Z NONE

Test looks good. Let's make those adjustments you put in the TODO and add one for the other function?

@max-sixty, do you mean to add a TODO to the function mentioned in this commit: https://github.com/pydata/xarray/pull/3550/commits/d57eb7cfaf1407179080f0ca95e7951e5622b493?

Here, I think the @requires_scipy_or_netCDF4 is actually necessary: python @requires_scipy_or_netCDF4 @requires_dask @pytest.mark.filterwarnings("ignore:use make_scale(name) instead") def test_open_mfdataset_manyfiles(

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   525685973