home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 557872510

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3550#issuecomment-557872510 https://api.github.com/repos/pydata/xarray/issues/3550 557872510 MDEyOklzc3VlQ29tbWVudDU1Nzg3MjUxMA== 45787861 2019-11-24T09:39:30Z 2019-11-24T09:39:30Z NONE

I would start with having the code in the function; i.e. don't abstract too early unless we're really confident on the eventual state. When we find ourselves something multiple times, then we can start pulling it out into more abstractions (e.g. fixtures).

Alright! I found myself having very similar tests and therefore abstracted it to test_func. I completely agree with not abstracting too early and but when having the same structure several times.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  525685973
Powered by Datasette · Queries took 0.854ms · About: xarray-datasette