issue_comments: 557790321

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue

html_url	issue_url	id	node_id	user	created_at	updated_at	author_association	body	reactions	performed_via_github_app	issue
https://github.com/pydata/xarray/pull/3550#issuecomment-557790321	https://api.github.com/repos/pydata/xarray/issues/3550	557790321	MDEyOklzc3VlQ29tbWVudDU1Nzc5MDMyMQ==	45787861	2019-11-23T11:34:12Z	2019-11-23T11:34:12Z	NONE	PS: I personally would like to use cov and corr also with dask. Does it also make sense to put this in a future PR, together with the above-mentioned other improvements? Further PRs: * Add `dot`, `cov` and `corr` to `computation.rst` > PS: It looks like `xr.dot` is only present in the "API reference" and not in https://xarray.pydata.org/en/stable/computation.html. We should add `dot`, `cov` and `corr` to `computation.rst` in a future PR. * Test (and if necessary implement) `dask` compatibility to `cov` and `corr` * Improve documentation on `How to contribute to the xarray documentation?` > I think it already gives a good overview, but then it might be unclear how to proceed. > Maybe it might make sense to add a subsection `How to contribute to the xarray documentation?` in which the different options are shortly described examplary: > ``` > 1. change docstring, e.g. .... > 2. update api.rst, e.g. .... > 3. update whats-new.rst, e.g. ... > ``` > > > Then, underline that building the documentation locally is optional: > ``` > Optionally, you can build the docs locally as described in the next section. > ``` Further PRs: Add dot, cov and corr to computation.rst `PS: It looks like xr.dot is only present in the "API reference" and not in https://xarray.pydata.org/en/stable/computation.html. We should add dot, cov and corr to computation.rst in a future PR.` Test (and if necessary implement) dask compatibility to cov and corr Improve documentation on How to contribute to the xarray documentation? `I think it already gives a good overview, but then it might be unclear how to proceed. Maybe it might make sense to add a subsection How to contribute to the xarray documentation? in which the different options are shortly described examplary: 1. change docstring, e.g. .... 2. update api.rst, e.g. .... 3. update whats-new.rst, e.g. ... Then, underline that building the documentation locally is optional: Optionally, you can build the docs locally as described in the next section.` Extend xarray functionality, such that pairwise correlations and covariances can be easily calculated. Either write a wrapper function or extend xr.corr and xr.cov, such that the following computation is supported with ease: `python pairwise_dim = 'space' for region in da_a[pairwise_dim]: print(xr.corr(da_a.sel(space=region.item()), da_a, dim='time').values)` Target output would be an xarray with pairwise correlations, e.g.: `bash [ 1. -0.43942827 -0.22425502] [-0.43942827 1. 0.30940081] [-0.22425502 0.30940081 1. ]`	{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }		525685973

https://github.com/pydata/xarray/pull/3550#issuecomment-557790321

https://api.github.com/repos/pydata/xarray/issues/3550

557790321

MDEyOklzc3VlQ29tbWVudDU1Nzc5MDMyMQ==

45787861

2019-11-23T11:34:12Z

NONE

PS: I personally would like to use cov and corr also with dask. Does it also make sense to put this in a future PR, together with the above-mentioned other improvements?

Further PRs:

* Add `dot`, `cov` and `corr` to `computation.rst`
  > PS: It looks like `xr.dot` is only present in the "API reference" and not in https://xarray.pydata.org/en/stable/computation.html. We should add `dot`, `cov` and `corr` to `computation.rst` in a future PR.

* Test (and if necessary implement) `dask` compatibility to `cov` and `corr`

* Improve documentation on `How to contribute to the xarray documentation?`
  > I think it already gives a good overview, but then it might be unclear how to proceed.
  > Maybe it might make sense to add a subsection `How to contribute to the xarray documentation?` in which the different options are shortly described examplary:
  > ```
  > 1. change docstring, e.g. ....
  > 2. update api.rst, e.g. ....
  > 3. update whats-new.rst, e.g. ...
  > ```
  > 
  > 
  > Then, underline that building the documentation locally is optional:
  > ```
  > Optionally, you can build the docs locally as described in the next section.
  > ```

Further PRs:

Add dot, cov and corr to computation.rst

PS: It looks like xr.dot is only present in the "API reference" and not in https://xarray.pydata.org/en/stable/computation.html. We should add dot, cov and corr to computation.rst in a future PR.

Test (and if necessary implement) dask compatibility to cov and corr

Improve documentation on How to contribute to the xarray documentation?

I think it already gives a good overview, but then it might be unclear how to proceed.

Maybe it might make sense to add a subsection How to contribute to the xarray documentation? in which the different options are shortly described examplary:

1. change docstring, e.g. ....
2. update api.rst, e.g. ....
3. update whats-new.rst, e.g. ...

Then, underline that building the documentation locally is optional:

Optionally, you can build the docs locally as described in the next section.

Extend xarray functionality, such that pairwise correlations and covariances can be easily calculated. Either write a wrapper function or extend xr.corr and xr.cov, such that the following computation is supported with ease: python pairwise_dim = 'space' for region in da_a[pairwise_dim]: print(xr.corr(da_a.sel(space=region.item()), da_a, dim='time').values) Target output would be an xarray with pairwise correlations, e.g.: bash [ 1. -0.43942827 -0.22425502] [-0.43942827 1. 0.30940081] [-0.22425502 0.30940081 1. ]

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}

525685973