issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR" and issue = 937336962 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • dataset `__repr__` updates · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
874329258 https://github.com/pydata/xarray/pull/5580#issuecomment-874329258 https://api.github.com/repos/pydata/xarray/issues/5580 MDEyOklzc3VlQ29tbWVudDg3NDMyOTI1OA== github-actions[bot] 41898282 2021-07-05T21:08:14Z 2021-08-10T19:56:28Z CONTRIBUTOR

Unit Test Results

4 files           4 suites   35m 31s :stopwatch: 16 210 tests 14 475 :heavy_check_mark: 1 735 :zzz: 0 :x: 60 304 runs  54 880 :heavy_check_mark: 5 424 :zzz: 0 :x:

Results for commit 4239b90a.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset `__repr__` updates 937336962
877021079 https://github.com/pydata/xarray/pull/5580#issuecomment-877021079 https://api.github.com/repos/pydata/xarray/issues/5580 MDEyOklzc3VlQ29tbWVudDg3NzAyMTA3OQ== st-bender 28786187 2021-07-09T08:41:15Z 2021-07-09T08:55:14Z CONTRIBUTOR

@keewis Thanks for the pointers, I'd say that nothing public facing should change in 0.18 now. OT (edit): By the way, these incompatibilities happen when one side decides to change the API without considering that some users may actually use that interface (and looking at the pandas' "deprecation" list, I fear that this will only get worse). Nice from the xarray people to have a section about keeping backwards compatibility as much as possible in their contribution guidelines.

As for the tests, I found the tests that @max-sixty put in and extended them (see second and third commits in this PR). However, now there is one dataset setup and then 4(!) asserts, which seems to be too much to follow nicely. Imagine all of them break, you fix the first, only to find out that the second breaks as well. so you fix that, only to find out that the third breaks too, and so on.

@Illviljan It is a good idea, however, I'd prefer if those changes were introduced as an option first, before changing the default behaviour.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset `__repr__` updates 937336962
875075222 https://github.com/pydata/xarray/pull/5580#issuecomment-875075222 https://api.github.com/repos/pydata/xarray/issues/5580 MDEyOklzc3VlQ29tbWVudDg3NTA3NTIyMg== st-bender 28786187 2021-07-06T20:55:49Z 2021-07-06T21:02:46Z CONTRIBUTOR

Hi @max-sixty, Sure, but it will take a bit. Could you point me to right places for the docs? Just the filenames would do.

I would be in favour of waiting a little with this change to get a few more opinions. This change will ignore display_max_rows for everything except dataset.__repr__, which may not be what some people might expect or hope. Any ideas how to get more people to weigh in?

Edit: I would also like to separate the tests, to make it easier to follow if something breaks, but the setup for the test dataset would be the same. Any preferences or best practices for the code layout in such a case without duplicating too much of the code? However, that can probably wait for another PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset `__repr__` updates 937336962

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);