issue_comments: 877021079

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5580#issuecomment-877021079 https://api.github.com/repos/pydata/xarray/issues/5580 877021079 MDEyOklzc3VlQ29tbWVudDg3NzAyMTA3OQ== 28786187 2021-07-09T08:41:15Z 2021-07-09T08:55:14Z CONTRIBUTOR

@keewis Thanks for the pointers, I'd say that nothing public facing should change in 0.18 now. OT (edit): By the way, these incompatibilities happen when one side decides to change the API without considering that some users may actually use that interface (and looking at the pandas' "deprecation" list, I fear that this will only get worse). Nice from the xarray people to have a section about keeping backwards compatibility as much as possible in their contribution guidelines.

As for the tests, I found the tests that @max-sixty put in and extended them (see second and third commits in this PR). However, now there is one dataset setup and then 4(!) asserts, which seems to be too much to follow nicely. Imagine all of them break, you fix the first, only to find out that the second breaks as well. so you fix that, only to find out that the third breaks too, and so on.

@Illviljan It is a good idea, however, I'd prefer if those changes were introduced as an option first, before changing the default behaviour.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   937336962