home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 875075222

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5580#issuecomment-875075222 https://api.github.com/repos/pydata/xarray/issues/5580 875075222 MDEyOklzc3VlQ29tbWVudDg3NTA3NTIyMg== 28786187 2021-07-06T20:55:49Z 2021-07-06T21:02:46Z CONTRIBUTOR

Hi @max-sixty, Sure, but it will take a bit. Could you point me to right places for the docs? Just the filenames would do.

I would be in favour of waiting a little with this change to get a few more opinions. This change will ignore display_max_rows for everything except dataset.__repr__, which may not be what some people might expect or hope. Any ideas how to get more people to weigh in?

Edit: I would also like to separate the tests, to make it easier to follow if something breaks, but the setup for the test dataset would be the same. Any preferences or best practices for the code layout in such a case without duplicating too much of the code? However, that can probably wait for another PR.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  937336962
Powered by Datasette · Queries took 0.884ms · About: xarray-datasette