issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR" and issue = 430460404 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Reduce length of cftime resample tests · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
481229888 https://github.com/pydata/xarray/pull/2879#issuecomment-481229888 https://api.github.com/repos/pydata/xarray/issues/2879 MDEyOklzc3VlQ29tbWVudDQ4MTIyOTg4OA== jwenfai 8708062 2019-04-09T12:26:43Z 2019-04-09T12:26:43Z CONTRIBUTOR

Wow, that's quick. The updated tests look fine to me so go ahead and merge it.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reduce length of cftime resample tests 430460404
481195895 https://github.com/pydata/xarray/pull/2879#issuecomment-481195895 https://api.github.com/repos/pydata/xarray/issues/2879 MDEyOklzc3VlQ29tbWVudDQ4MTE5NTg5NQ== jwenfai 8708062 2019-04-09T10:29:05Z 2019-04-09T10:29:05Z CONTRIBUTOR

Thanks for taking on the task of shortening test times! If the coverage is the same, I think the rewritten tests should be good.

Just two things I feel I should mention: - Testing even and odd multiples for resampling frequencies for a frequency class (e.g., '11MS' and '12M' for monthlies) I don't quite remember what the issue was but there were tests that passed for even/odd resampling frequencies but fail for the other. Perhaps the tests could be rewritten to (1) switch da_freq and freq and (2) use odd frequencies for constructing the DataArray so that when * 2 and \\ 2 operations are performed, even and odd resampling frequencies are obtained. There were some issues with resampling to 12H so maybe use a frequency that multiplies or divides to 12H. - Testing resampling from one freq type to another (e.g., from '3Q' to '11MS') Again I don't remember the details other than that a problem exists/existed. Perhaps something to do with _get_range_edges since that's the part of the code where the original index of a DataArray interacts with the resampling frequency.

Both of the problems I mentioned might have been from the earliest iteration of CFTimeIndex resampling so they might have no relevance now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reduce length of cftime resample tests 430460404

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);