issue_comments: 481195895
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/2879#issuecomment-481195895 | https://api.github.com/repos/pydata/xarray/issues/2879 | 481195895 | MDEyOklzc3VlQ29tbWVudDQ4MTE5NTg5NQ== | 8708062 | 2019-04-09T10:29:05Z | 2019-04-09T10:29:05Z | CONTRIBUTOR | Thanks for taking on the task of shortening test times! If the coverage is the same, I think the rewritten tests should be good. Just two things I feel I should mention:
- Testing even and odd multiples for resampling frequencies for a frequency class (e.g., '11MS' and '12M' for monthlies)
I don't quite remember what the issue was but there were tests that passed for even/odd resampling frequencies but fail for the other. Perhaps the tests could be rewritten to (1) switch Both of the problems I mentioned might have been from the earliest iteration of CFTimeIndex resampling so they might have no relevance now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
430460404 |