issues: 430460404
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
430460404 | MDExOlB1bGxSZXF1ZXN0MjY4MzQzMTM1 | 2879 | Reduce length of cftime resample tests | 6628425 | closed | 0 | 5 | 2019-04-08T13:44:50Z | 2019-04-11T11:42:16Z | 2019-04-11T11:42:09Z | MEMBER | 0 | pydata/xarray/pulls/2879 | The main issue is that we were resampling the same time indexes across a large range of frequencies, in some cases producing very long results, e.g. resampling an index that spans 27 years to a frequency of 12 hours. This modifies the primary test so that it constructs time indexes whose ranges are based on the frequencies we resample to. Now in total the tests in @jwenfai I did some coverage analysis offline, and these tests produce the same coverage that we had before (I found it necessary to be sure to test cases where the reference index had either a shorter or longer frequency than the resample frequency). Do you think what I have here is sufficient? I think we could potentially shorten things even more, but I'm not sure if it's worth the effort.
See below for the new profiling results; now the longest cftime tests are no longer associated with resample.
|
{ "url": "https://api.github.com/repos/pydata/xarray/issues/2879/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |