issue_comments

Table actions

6 rows where issue = 374849806 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Deprecate inplace · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
435621982 https://github.com/pydata/xarray/pull/2524#issuecomment-435621982 https://api.github.com/repos/pydata/xarray/issues/2524 MDEyOklzc3VlQ29tbWVudDQzNTYyMTk4Mg== shoyer 1217238 2018-11-03T21:24:18Z 2018-11-03T21:24:18Z MEMBER

thanks @dcherian 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace 374849806
434887467 https://github.com/pydata/xarray/pull/2524#issuecomment-434887467 https://api.github.com/repos/pydata/xarray/issues/2524 MDEyOklzc3VlQ29tbWVudDQzNDg4NzQ2Nw== shoyer 1217238 2018-11-01T00:00:37Z 2018-11-01T00:00:37Z MEMBER

_calculate_binary_op shouldn't lose the inplace argument -- it's used for Python inplace arithmetic like +=. On Wed, Oct 31, 2018 at 12:00 PM Deepak Cherian notifications@github.com wrote:

OK so what's left is Dataset._calculate_binary_op(g, other, inplace=True) called by Dataset._inplace_binary_op at Line 3307 in dataset.py. I don't know what the right fix is.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2524#issuecomment-434802366, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1m-T_2r1AXYZxnQtFr3NNXEPoNgeks5uqfNEgaJpZM4X-bI- . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace 374849806
434802366 https://github.com/pydata/xarray/pull/2524#issuecomment-434802366 https://api.github.com/repos/pydata/xarray/issues/2524 MDEyOklzc3VlQ29tbWVudDQzNDgwMjM2Ng== dcherian 2448579 2018-10-31T18:42:14Z 2018-10-31T18:42:14Z MEMBER

OK so what's left is Dataset._calculate_binary_op(g, other, inplace=True) called by Dataset._inplace_binary_op at Line 3307 in dataset.py. I don't know what the right fix is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace 374849806
434491155 https://github.com/pydata/xarray/pull/2524#issuecomment-434491155 https://api.github.com/repos/pydata/xarray/issues/2524 MDEyOklzc3VlQ29tbWVudDQzNDQ5MTE1NQ== shoyer 1217238 2018-10-30T22:20:26Z 2018-10-30T22:20:26Z MEMBER

In general, I would be OK with not testing inplace behavior carefully. We can certainly add this to specific test methods but overall I think it's better to have slightly less test coverage of deprecated behavior rather than to raise deprecation warnings as part of unrelated operations.

On Tue, Oct 30, 2018 at 3:06 PM Deepak Cherian notifications@github.com wrote:

@dcherian commented on this pull request.

In xarray/tests/test_dataarray.py https://github.com/pydata/xarray/pull/2524#discussion_r229503613:

@@ -23,6 +23,7 @@ requires_scipy, source_ndarray)

+@pytest.mark.filterwarnings('ignore:The inplace argument')

Oh I haven't checked that closely but I can do that tonight. (my impression was that the tests were testing inplace behaviour, but I see that could be wrong)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2524#discussion_r229503613, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1nCL0fqW2POPBepyKA2R4lxQGGONks5uqM1ZgaJpZM4X-bI- . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace 374849806
434455085 https://github.com/pydata/xarray/pull/2524#issuecomment-434455085 https://api.github.com/repos/pydata/xarray/issues/2524 MDEyOklzc3VlQ29tbWVudDQzNDQ1NTA4NQ== dcherian 2448579 2018-10-30T20:21:46Z 2018-10-30T20:21:46Z MEMBER

Failed test is dask distributed test

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace 374849806
433781652 https://github.com/pydata/xarray/pull/2524#issuecomment-433781652 https://api.github.com/repos/pydata/xarray/issues/2524 MDEyOklzc3VlQ29tbWVudDQzMzc4MTY1Mg== pep8speaks 24736507 2018-10-29T03:59:45Z 2018-10-29T03:59:45Z NONE

Hello @dcherian! Thanks for submitting the PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace 374849806

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);