issue_comments: 434887467

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2524#issuecomment-434887467 https://api.github.com/repos/pydata/xarray/issues/2524 434887467 MDEyOklzc3VlQ29tbWVudDQzNDg4NzQ2Nw== 1217238 2018-11-01T00:00:37Z 2018-11-01T00:00:37Z MEMBER

_calculate_binary_op shouldn't lose the inplace argument -- it's used for Python inplace arithmetic like +=. On Wed, Oct 31, 2018 at 12:00 PM Deepak Cherian notifications@github.com wrote:

OK so what's left is Dataset._calculate_binary_op(g, other, inplace=True) called by Dataset._inplace_binary_op at Line 3307 in dataset.py. I don't know what the right fix is.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2524#issuecomment-434802366, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1m-T_2r1AXYZxnQtFr3NNXEPoNgeks5uqfNEgaJpZM4X-bI- . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   374849806